runtime/vm/intermediate_language_arm.cc - Issue 1416233003: Fix some loads of fields with large offsets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 1416233003: Fix some loads of fields with large offsets. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language_arm.cc

diff --git a/runtime/vm/intermediate_language_arm.cc b/runtime/vm/intermediate_language_arm.cc

index f7030f816e34103c9e65b80b81132655f5c1055a..cf80376431fd2459d7943aafa0dadd35fa73d71f 100644

--- a/runtime/vm/intermediate_language_arm.cc

+++ b/runtime/vm/intermediate_language_arm.cc

@@ -2445,7 +2445,7 @@ void LoadFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

if (IsUnboxedLoad() && compiler->is_optimizing()) {

const DRegister result = EvenDRegisterOf(locs()->out(0).fpu_reg());

const Register temp = locs()->temp(0).reg();

- __ ldr(temp, FieldAddress(instance_reg, offset_in_bytes()));

+ __ LoadFieldFromOffset(kWord, temp, instance_reg, offset_in_bytes());

const intptr_t cid = field()->UnboxedFieldCid();

switch (cid) {

case kDoubleCid:

« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »