Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: runtime/vm/intermediate_language_mips.cc

Issue 1416233003: Fix some loads of fields with large offsets. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | tests/language/language.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 2282 matching lines...) Expand 10 before | Expand all | Expand 10 after
2293 } 2293 }
2294 2294
2295 2295
2296 void LoadFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 2296 void LoadFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
2297 ASSERT(sizeof(classid_t) == kInt16Size); 2297 ASSERT(sizeof(classid_t) == kInt16Size);
2298 2298
2299 Register instance_reg = locs()->in(0).reg(); 2299 Register instance_reg = locs()->in(0).reg();
2300 if (IsUnboxedLoad() && compiler->is_optimizing()) { 2300 if (IsUnboxedLoad() && compiler->is_optimizing()) {
2301 DRegister result = locs()->out(0).fpu_reg(); 2301 DRegister result = locs()->out(0).fpu_reg();
2302 Register temp = locs()->temp(0).reg(); 2302 Register temp = locs()->temp(0).reg();
2303 __ lw(temp, FieldAddress(instance_reg, offset_in_bytes())); 2303 __ LoadFieldFromOffset(temp, instance_reg, offset_in_bytes());
2304 intptr_t cid = field()->UnboxedFieldCid(); 2304 intptr_t cid = field()->UnboxedFieldCid();
2305 switch (cid) { 2305 switch (cid) {
2306 case kDoubleCid: 2306 case kDoubleCid:
2307 __ LoadDFromOffset(result, temp, 2307 __ LoadDFromOffset(result, temp,
2308 Double::value_offset() - kHeapObjectTag); 2308 Double::value_offset() - kHeapObjectTag);
2309 break; 2309 break;
2310 default: 2310 default:
2311 UNREACHABLE(); 2311 UNREACHABLE();
2312 } 2312 }
2313 return; 2313 return;
(...skipping 3289 matching lines...) Expand 10 before | Expand all | Expand 10 after
5603 1, 5603 1,
5604 locs()); 5604 locs());
5605 __ lw(result, Address(SP, 1 * kWordSize)); 5605 __ lw(result, Address(SP, 1 * kWordSize));
5606 __ addiu(SP, SP, Immediate(2 * kWordSize)); 5606 __ addiu(SP, SP, Immediate(2 * kWordSize));
5607 } 5607 }
5608 5608
5609 5609
5610 } // namespace dart 5610 } // namespace dart
5611 5611
5612 #endif // defined TARGET_ARCH_MIPS 5612 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698