Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 1416233003: Fix some loads of fields with large offsets. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 930 matching lines...) Expand 10 before | Expand all | Expand 10 after
941 __ b(&null_args_loop, PL); 941 __ b(&null_args_loop, PL);
942 } 942 }
943 943
944 944
945 void FlowGraphCompiler::GenerateInlinedGetter(intptr_t offset) { 945 void FlowGraphCompiler::GenerateInlinedGetter(intptr_t offset) {
946 // LR: return address. 946 // LR: return address.
947 // SP: receiver. 947 // SP: receiver.
948 // Sequence node has one return node, its input is load field node. 948 // Sequence node has one return node, its input is load field node.
949 __ Comment("Inlined Getter"); 949 __ Comment("Inlined Getter");
950 __ ldr(R0, Address(SP, 0 * kWordSize)); 950 __ ldr(R0, Address(SP, 0 * kWordSize));
951 __ LoadFromOffset(kWord, R0, R0, offset - kHeapObjectTag); 951 __ LoadFieldFromOffset(kWord, R0, R0, offset);
952 __ Ret(); 952 __ Ret();
953 } 953 }
954 954
955 955
956 void FlowGraphCompiler::GenerateInlinedSetter(intptr_t offset) { 956 void FlowGraphCompiler::GenerateInlinedSetter(intptr_t offset) {
957 // LR: return address. 957 // LR: return address.
958 // SP+1: receiver. 958 // SP+1: receiver.
959 // SP+0: value. 959 // SP+0: value.
960 // Sequence node has one store node and one return NULL node. 960 // Sequence node has one store node and one return NULL node.
961 __ Comment("Inlined Setter"); 961 __ Comment("Inlined Setter");
(...skipping 911 matching lines...) Expand 10 before | Expand all | Expand 10 after
1873 DRegister dreg = EvenDRegisterOf(reg); 1873 DRegister dreg = EvenDRegisterOf(reg);
1874 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex)); 1874 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex));
1875 } 1875 }
1876 1876
1877 1877
1878 #undef __ 1878 #undef __
1879 1879
1880 } // namespace dart 1880 } // namespace dart
1881 1881
1882 #endif // defined TARGET_ARCH_ARM 1882 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698