Add NormalizingInputFilterWin to un-pick AltGr sequences.

Add NormalizingInputFilterWin to un-pick AltGr sequences.

Windows treats international keyboard layouts' AltGr modifier as a
combination of left-Control and right-Alt modifiers, whereas the
Chromoting protocol, and other platforms, treat AltGr as equivalent to
right-Alt and handle the Alt/AltGr as part of the layout-specific
meaning of the key.

NormalizingInputFilterWin holds each keydown event for the left-Control
key until the next input event (e.g. left-Control repeat, another key
event, mouse event, etc) so that it can suppress it if the next event is
a keydown for right-Alt, on the assumption that that indicates an AltGr
sequence.

BUG=470571
Committed: https://crrev.com/ae3b75a1cd6d47607a789b5d0adba80f8fc3ebe4
Cr-Commit-Position: refs/heads/master@{#355881}

[Wez, 2015-10-22 04:52:14]

wez@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Wez, 2015-10-22 04:52:15]

PTAL

[Wez, 2015-10-22 23:37:17]

wez@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Sergey Ulanov, 2015-10-23 00:12:53]

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
File remoting/client/normalizing_input_filter_win.cc (right):

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
remoting/client/normalizing_input_filter_win.cc:13: const unsigned int
kUsbLeftControl = 0x0700e0;
You can include ui/events/keycodes/dom/dom_code.h and use it here. ChromeOS
filter does that.

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
remoting/client/normalizing_input_filter_win.cc:21:
left_control_is_pressed_(false),
move these initializers to the header.

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
remoting/client/normalizing_input_filter_win.cc:32: ProcessKeyDown(event);
add {} please

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
remoting/client/normalizing_input_filter_win.cc:58: if
(deferred_keydown_event_.has_usb_keycode())
This condition is duplicated in 3 places. Move it to
FlushDeferredKeydownEvent()?

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
File remoting/client/normalizing_input_filter_win.h (right):

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
remoting/client/normalizing_input_filter_win.h:45: protocol::KeyEvent
deferred_keydown_event_;
Maybe call it deferred_control_keydown_event_?

[Wez, 2015-10-23 01:18:56]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 01:20:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416233002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416233002/40001

[commit-bot: I haz the power, 2015-10-23 02:03:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 02:03:06]

Dry run: This issue passed the CQ dry run.

[Wez, 2015-10-23 20:03:26]

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
File remoting/client/normalizing_input_filter_win.cc (right):

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
remoting/client/normalizing_input_filter_win.cc:13: const unsigned int
kUsbLeftControl = 0x0700e0;
On 2015/10/23 at 00:12:53, Sergey Ulanov wrote:
> You can include ui/events/keycodes/dom/dom_code.h and use it here. ChromeOS
filter does that.

Done!

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
remoting/client/normalizing_input_filter_win.cc:21:
left_control_is_pressed_(false),
On 2015/10/23 at 00:12:53, Sergey Ulanov wrote:
> move these initializers to the header.

Done

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
remoting/client/normalizing_input_filter_win.cc:32: ProcessKeyDown(event);
On 2015/10/23 at 00:12:53, Sergey Ulanov wrote:
> add {} please

Done for this block; were you meaning just this one, because of the else?

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
remoting/client/normalizing_input_filter_win.cc:58: if
(deferred_keydown_event_.has_usb_keycode())
On 2015/10/23 at 00:12:53, Sergey Ulanov wrote:
> This condition is duplicated in 3 places. Move it to
FlushDeferredKeydownEvent()?

Done.

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
File remoting/client/normalizing_input_filter_win.h (right):

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
remoting/client/normalizing_input_filter_win.h:45: protocol::KeyEvent
deferred_keydown_event_;
On 2015/10/23 at 00:12:53, Sergey Ulanov wrote:
> Maybe call it deferred_control_keydown_event_?

I'd prefer to keep the name shorter - perhaps deferred_control_keydown_?

[Sergey Ulanov, 2015-10-23 20:46:56]

lgtm

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
File remoting/client/normalizing_input_filter_win.cc (right):

https://codereview.chromium.org/1416233002/diff/20001/remoting/client/normali...
remoting/client/normalizing_input_filter_win.cc:32: ProcessKeyDown(event);
On 2015/10/23 20:03:26, Wez wrote:
> On 2015/10/23 at 00:12:53, Sergey Ulanov wrote:
> > add {} please
> 
> Done for this block; were you meaning just this one, because of the else?

Yes.

[Wez, 2015-10-23 20:57:01]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2015-10-23 20:58:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416233002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416233002/40001

[commit-bot: I haz the power, 2015-10-23 21:07:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-23 21:08:25]

Patchset 3 (id:??) landed as
https://crrev.com/ae3b75a1cd6d47607a789b5d0adba80f8fc3ebe4
Cr-Commit-Position: refs/heads/master@{#355881}