Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 1416223004: Add 'build' directory to import path of gyp_chromium. (Closed)

Created:
5 years, 1 month ago by bcwhite
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add 'build' directory to import path of gyp_chromium. Change https://codereview.chromium.org/1418513007/ moved a module from tools/ to build/ causing gyp_chromium to import a different module of the same name and breaking because the function names are different. BUG= Committed: https://crrev.com/d9aaae0056107fc54f7d068b8baa8648b6615054 Cr-Commit-Position: refs/heads/master@{#356842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/gyp_chromium.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bcwhite
5 years, 1 month ago (2015-10-29 14:11:58 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-10-29 14:37:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416223004/1
5 years, 1 month ago (2015-10-29 14:55:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 15:08:12 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 15:09:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9aaae0056107fc54f7d068b8baa8648b6615054
Cr-Commit-Position: refs/heads/master@{#356842}

Powered by Google App Engine
This is Rietveld 408576698