Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: src/platform-freebsd.cc

Issue 14162004: Unified the structure of VirtualMemory implementations across platforms a bit. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/platform-cygwin.cc ('k') | src/platform-linux.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
351 free(symbols); 351 free(symbols);
352 352
353 return frames_count; 353 return frames_count;
354 } 354 }
355 355
356 356
357 // Constants used for mmap. 357 // Constants used for mmap.
358 static const int kMmapFd = -1; 358 static const int kMmapFd = -1;
359 static const int kMmapFdOffset = 0; 359 static const int kMmapFdOffset = 0;
360 360
361
361 VirtualMemory::VirtualMemory() : address_(NULL), size_(0) { } 362 VirtualMemory::VirtualMemory() : address_(NULL), size_(0) { }
362 363
363 VirtualMemory::VirtualMemory(size_t size) { 364
364 address_ = ReserveRegion(size); 365 VirtualMemory::VirtualMemory(size_t size)
365 size_ = size; 366 : address_(ReserveRegion(size)), size_(size) { }
366 }
367 367
368 368
369 VirtualMemory::VirtualMemory(size_t size, size_t alignment) 369 VirtualMemory::VirtualMemory(size_t size, size_t alignment)
370 : address_(NULL), size_(0) { 370 : address_(NULL), size_(0) {
371 ASSERT(IsAligned(alignment, static_cast<intptr_t>(OS::AllocateAlignment()))); 371 ASSERT(IsAligned(alignment, static_cast<intptr_t>(OS::AllocateAlignment())));
372 size_t request_size = RoundUp(size + alignment, 372 size_t request_size = RoundUp(size + alignment,
373 static_cast<intptr_t>(OS::AllocateAlignment())); 373 static_cast<intptr_t>(OS::AllocateAlignment()));
374 void* reservation = mmap(OS::GetRandomMmapAddr(), 374 void* reservation = mmap(OS::GetRandomMmapAddr(),
375 request_size, 375 request_size,
376 PROT_NONE, 376 PROT_NONE,
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
920 920
921 921
922 void Sampler::Stop() { 922 void Sampler::Stop() {
923 ASSERT(IsActive()); 923 ASSERT(IsActive());
924 SignalSender::RemoveActiveSampler(this); 924 SignalSender::RemoveActiveSampler(this);
925 SetActive(false); 925 SetActive(false);
926 } 926 }
927 927
928 928
929 } } // namespace v8::internal 929 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/platform-cygwin.cc ('k') | src/platform-linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698