Issue 14162004: Unified the structure of VirtualMemory implementations across platforms a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14162004: Unified the structure of VirtualMemory implementations across platforms a bit. (Closed)

Created:
7 years, 8 months ago by Sven Panne

Modified:
7 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Unified the structure of VirtualMemory implementations across platforms a bit. This is just shuffling some code around to make comparing the platform files easier. Made cygwin/nullos support a bit more complete on the way. Committed: http://code.google.com/p/v8/source/detail?r=14250

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+124 lines, -56 lines)			Patch
M	src/platform-cygwin.cc	View	3 chunks	+37 lines, -7 lines	0 comments	Download
M	src/platform-freebsd.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/platform-linux.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/platform-macos.cc	View	3 chunks	+21 lines, -21 lines	0 comments	Download
M	src/platform-nullos.cc	View	3 chunks	+39 lines, -0 lines	0 comments	Download
M	src/platform-openbsd.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/platform-solaris.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/platform-win32.cc	View	3 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

7 years, 8 months ago (2013-04-12 11:10:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14250 (presubmit successful).

Expand Messages | Collapse Messages