third_party/WebKit/Source/bindings/core/v8/ScriptValue.h - Issue 1416163003: Reland "Don't report promise rejection events during the microtask checkpoint"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptValue.h

Issue 1416163003: Reland "Don't report promise rejection events during the microtask checkpoint" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h ('k') | third_party/WebKit/Source/bindings/core/v8/SharedPersistent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptValue.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptValue.h b/third_party/WebKit/Source/bindings/core/v8/ScriptValue.h

index bb139370eb30911c5d7460c5c29afee341b73241..44367d363e23f0d3ce7e1edac8c20ae56e8a0424 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptValue.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptValue.h

@@ -181,6 +181,17 @@ public:

m_value->setReference(parent, isolate);

}

+ template<typename P>

+ void setWeak(P* parameters, void (*callback)(const v8::WeakCallbackInfo<P>&), v8::WeakCallbackType type = v8::WeakCallbackType::kParameter)

+ {

+ m_value->setWeak(parameters, callback, type);

+ }

+ void clearWeak()

+ {

+ m_value->clearWeak();

+ }

static ScriptValue createNull(ScriptState*);

private: