chrome/chrome_tests_unit.gypi - Issue 1416133003: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 1416133003: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gn secondary, mac .S not on windows Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_tests_unit.gypi

diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi

index 8cec80c1e2cd8277d2ffef94b3debdb9cb57f9ef..a04a3b080d93975e1cb3b859b66a7fc05e5000fa 100644

--- a/chrome/chrome_tests_unit.gypi

+++ b/chrome/chrome_tests_unit.gypi

@@ -2053,13 +2053,13 @@

'include_dirs': [

'<(DEPTH)/third_party/wtl/include',

- 'conditions': [

- ['use_aura==1', {

- 'dependencies': [

- '../win8/win8.gyp:test_registrar_constants',

- '../win8/win8.gyp:test_support_win8',

- ],

- }],

+ 'dependencies': [

+ '../components/components.gyp:crash_component',

+ '../win8/win8.gyp:test_registrar_constants',

+ '../win8/win8.gyp:test_support_win8',

+ ],

+ 'sources': [

+ 'app/chrome_crash_reporter_client.cc',

Mark Mentovai 2015/11/19 22:21:37 Weird file, being built in several targets…

scottmg 2015/11/20 19:52:48 Yeah, I don't love it. I'm hoping to simplify in f

}],

['OS=="win" or OS=="mac"', {

« chrome/app/chrome_main_delegate.cc ('K') | « chrome/chrome_installer.gypi ('k') | chrome/common/child_process_logging_win.cc » ('j') | chrome/common/chrome_switches.cc » ('J')