Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1589)

Unified Diff: chrome/app/chrome_crash_reporter_client.cc

Issue 1416133003: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add some stub gn files Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/DEPS ('k') | chrome/app/chrome_exe_main_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_crash_reporter_client.cc
diff --git a/chrome/app/chrome_crash_reporter_client.cc b/chrome/app/chrome_crash_reporter_client.cc
index 49c8c492624336f81b0f31bbe773d7108e676e0b..2663a08017ad0aef4a048deeffd8eb441465f9f1 100644
--- a/chrome/app/chrome_crash_reporter_client.cc
+++ b/chrome/app/chrome_crash_reporter_client.cc
@@ -292,17 +292,7 @@ bool ChromeCrashReporterClient::GetCrashDumpLocation(
}
size_t ChromeCrashReporterClient::RegisterCrashKeys() {
- // Note: On Windows this only affects the EXE. A separate invocation from
- // child_process_logging_win.cc registers crash keys for Chrome.dll.
-#if defined(OS_WIN) && defined(COMPONENT_BUILD)
- // On Windows, this is not called in a component build, as in that case a
- // single copy of 'base' is shared by the EXE and the various DLLs, and that
- // copy is configured by child_process_logging_win.cc.
- NOTREACHED();
- return 0;
-#else
return crash_keys::RegisterChromeCrashKeys();
-#endif
}
bool ChromeCrashReporterClient::IsRunningUnattended() {
« no previous file with comments | « chrome/app/DEPS ('k') | chrome/app/chrome_exe_main_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698