Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

chrome/app/chrome_exe_main_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <malloc.h>
+#include <shellapi.h>
 #include <shellscalingapi.h>
 #include <tchar.h>
 
 #include <string>
 
 #include "base/at_exit.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
+#include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/win/windows_version.h"
 #include "chrome/app/main_dll_loader_win.h"
 #include "chrome/browser/chrome_process_finder_win.h"
 #include "chrome/browser/policy/policy_path_parser.h"
 #include "chrome/common/chrome_paths_internal.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome_elf/chrome_elf_main.h"
 #include "components/startup_metric_utils/browser/startup_metric_utils.h"
 #include "content/public/common/result_codes.h"
+#include "third_party/crashpad/crashpad/handler/handler_main.h"
+#include "third_party/crashpad/crashpad/util/win/scoped_local_alloc.h"
 #include "ui/gfx/win/dpi.h"
 
 namespace {
 // List of switches that it's safe to rendezvous early with. Fast start should
 // not be done if a command line contains a switch not in this set.
 // Note this is currently stored as a list of two because it's probably faster
 // to iterate over this small array than building a map for constant time
 // lookups.
 const char* const kFastStartSwitches[] = {
   switches::kProfileDirectory,
@@ skipping 78 matching lines @@
   // Only needed on XP but harmless on other Windows flavors.
   auto crt_heap = _get_heap_handle();
   ULONG enable_LFH = 2;
   if (HeapSetInformation(reinterpret_cast<HANDLE>(crt_heap),
                          HeapCompatibilityInformation,
                          &enable_LFH, sizeof(enable_LFH))) {
     VLOG(1) << "Low fragmentation heap enabled.";
   }
 }
 
+bool RunAsCrashpadHandlerIfSpecified(int* rc) {

[cpu_(ooo_6.6-7.5), 2015/11/06 23:16:48]

don't like the "IfSpecified"

[scottmg, 2015/11/07 00:39:43]

Done.

+  int num_args;
+  wchar_t** args = CommandLineToArgvW(GetCommandLine(), &num_args);
+  crashpad::ScopedLocalAlloc scoped_args(args);  // Take ownership.
+  PCHECK(args) << "CommandLineToArgvW";
+
+  for (int i = 1; i < num_args; ++i) {
+    if (wcscmp(args[i], L"--crashpad_handler") == 0) {
+      // We're dropping args[i], so reserve one less than num_args for the

[cpu_(ooo_6.6-7.5), 2015/11/06 23:16:48]

is this not possible with base/command_line ?

[scottmg, 2015/11/07 00:39:42]

I have trust issues with how much that code does. Switched.

+      // arrays, but add an extra trailing null for the getopt implementation.
+      scoped_ptr<char* []> argv_as_utf8(new char*[num_args]);
+      std::vector<std::string> storage;
+      storage.reserve(num_args - 1);
+      for (int j = 0; j < num_args; ++j) {
+        if (j == i)
+          continue;
+        storage.push_back(base::UTF16ToUTF8(args[j]));
+      }
+      DCHECK_EQ(storage.size(), static_cast<size_t>(num_args - 1));
+      for (size_t j = 0; j < storage.size(); ++j)
+        argv_as_utf8[j] = &storage[j][0];
+      argv_as_utf8[num_args - 1] = nullptr;
+      *rc = crashpad::HandlerMain(num_args - 1, argv_as_utf8.get());
+      return true;
+    }
+  }
+  return false;
+}
+
 }  // namespace
 
 #if !defined(ADDRESS_SANITIZER)
 int APIENTRY wWinMain(HINSTANCE instance, HINSTANCE prev, wchar_t*, int) {
 #else
 // The AddressSanitizer build should be a console program as it prints out stuff
 // on stderr.
 int main() {
   HINSTANCE instance = GetModuleHandle(NULL);
 #endif
+  int rc;
+  if (RunAsCrashpadHandlerIfSpecified(&rc)) {
+    return rc;
+  }
+
   SwitchToLFHeap();
 
   startup_metric_utils::RecordExeMainEntryPointTime(base::Time::Now());
 
   // Signal Chrome Elf that Chrome has begun to start.
   SignalChromeElf();
 
   // Initialize the commandline singleton from the environment.
   base::CommandLine::Init(0, NULL);
   // The exit manager is in charge of calling the dtors of singletons.
   base::AtExitManager exit_manager;
 
   // We don't want to set DPI awareness on pre-Win7 because we don't support
   // DirectWrite there. GDI fonts are kerned very badly, so better to leave
   // DPI-unaware and at effective 1.0. See also ShouldUseDirectWrite().
   if (base::win::GetVersion() >= base::win::VERSION_WIN7)
     EnableHighDPISupport();
 
   if (AttemptFastNotify(*base::CommandLine::ForCurrentProcess()))
     return 0;
 
   // Load and launch the chrome dll. *Everything* happens inside.
   VLOG(1) << "About to load main DLL.";
   MainDllLoader* loader = MakeMainDllLoader();
-  int rc = loader->Launch(instance);
+  rc = loader->Launch(instance);
   loader->RelaunchChromeBrowserWithNewCommandLineIfNeeded();
   delete loader;
   return rc;
 }