Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

content/ppapi_plugin/ppapi_plugin_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/base_paths.h"
 #include "base/command_line.h"
+#include "base/debug/crash_logging.h"
 #include "base/debug/debugger.h"
 #include "base/files/file_path.h"
 #include "base/i18n/rtl.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/threading/platform_thread.h"
 #include "build/build_config.h"
 #include "content/child/child_process.h"
 #include "content/common/content_constants_internal.h"
 #include "content/common/sandbox_linux/sandbox_linux.h"
@@ skipping 45 matching lines @@
   ppapi::proxy::PluginGlobals::Get()->PreCacheFontForFlash(
       reinterpret_cast<const void*>(&logfont));
 }
 #endif
 
 }  // namespace
 
 // Main function for starting the PPAPI plugin process.
 int PpapiPluginMain(const MainFunctionParams& parameters) {
   const base::CommandLine& command_line = parameters.command_line;
+  base::debug::SetCrashKeyValue(
+      "plugin-path", command_line.GetSwitchValueASCII("plugin-path"));

[Mark Mentovai, 2015/11/21 14:53:07]

switches::kPluginPath for the one on the right side.

[scottmg, 2015/11/24 19:04:25]

I hadn't even checked, but looking now, it turns out we don't use the argument
for ppapi, so I just removed it entirely.

(e.g. from Canary:
"C:\Users\scott\AppData\Local\Google\Chrome SxS\Application\chrome.exe"
--type=ppapi --channel="15600.24.1123495397\746756095"
--ppapi-flash-args=enable_hw_video_decode=1 --lang=en-US
--device-scale-factor=1.5 --font-cache-shared-handle=12728 --ignored="
--type=renderer " /prefetch:-632637702
)

 
 #if defined(OS_WIN)
   g_target_services = parameters.sandbox_info->target_services;
 #endif
 
   // If |g_target_services| is not null this process is sandboxed. One side
   // effect is that we can't pop dialogs like ChildProcess::WaitForDebugger()
   // does.
   if (command_line.HasSwitch(switches::kPpapiStartupDialog)) {
     if (g_target_services)
@@ skipping 63 matching lines @@
 
   blink::WebFontRendering::setUseDirectWrite(use_direct_write);
   blink::WebFontRendering::setDeviceScaleFactor(gfx::GetDPIScale());
 #endif
 
   main_message_loop.Run();
   return 0;
 }
 
 }  // namespace content