Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1416123007: PPC: Disable gcc generation of fmadd/fmsub in cctests. (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Disable gcc generation of fmadd/fmsub in cctests. Generated code performs distinct floating multiply and add/subtract operations. Tests fail when GCC uses fmadd/fmsub to calculate the expected result since these instructions provide higher accuracy due to the lack of an intermediate round. R=machenbach@chromium.org BUG= Committed: https://crrev.com/40eeb69b94e2ca6fa69fd38d2453e84ce7c26b6d Cr-Commit-Position: refs/heads/master@{#31918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/cctest/cctest.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
MTBrandyberry
Common gyp file change.
5 years, 1 month ago (2015-11-09 21:39:46 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416123007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416123007/1
5 years, 1 month ago (2015-11-09 21:40:00 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-09 21:55:20 UTC) #7
Michael Achenbach
lgtm
5 years, 1 month ago (2015-11-10 06:58:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416123007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416123007/1
5 years, 1 month ago (2015-11-10 14:30:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 14:31:23 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 14:31:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40eeb69b94e2ca6fa69fd38d2453e84ce7c26b6d
Cr-Commit-Position: refs/heads/master@{#31918}

Powered by Google App Engine
This is Rietveld 408576698