third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 1416123005: Implement setSinkId() for media elements without src.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1416123005: Implement setSinkId() for media elements without src. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More jochen's comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp ('K') | « third_party/WebKit/Source/web/AudioOutputDeviceClientImpl.cpp ('k') | third_party/WebKit/Source/web/web.gypi » ('j') | third_party/WebKit/public/web/WebFrameClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 03285f6ddaaa82d7f08f30dd5fbcf67906660402..ad7aa4334676b4fc12924b4855beb62332dba443 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -156,6 +156,7 @@

#include "core/timing/DOMWindowPerformance.h"

#include "core/timing/Performance.h"

#include "modules/app_banner/AppBannerController.h"

+#include "modules/audio_output_devices/AudioOutputDeviceClient.h"

#include "modules/bluetooth/BluetoothSupplement.h"

#include "modules/geolocation/GeolocationController.h"

#include "modules/notifications/NotificationPermissionClient.h"

@@ -218,6 +219,7 @@

#include "public/web/WebTreeScopeType.h"

#include "skia/ext/platform_device.h"

#include "web/AssociatedURLLoader.h"

+#include "web/AudioOutputDeviceClientImpl.h"

#include "web/CompositionUnderlineVectorBuilder.h"

#include "web/FindInPageCoordinates.h"

#include "web/GeolocationClientProxy.h"

@@ -1728,6 +1730,8 @@ void WebLocalFrameImpl::setCoreFrame(PassRefPtrWillBeRawPtr<LocalFrame> frame)

VRController::provideTo(*m_frame, m_client ? m_client->webVRClient() : nullptr);

if (RuntimeEnabledFeatures::wakeLockEnabled())

ScreenWakeLock::provideTo(*m_frame, m_client ? m_client->wakeLockClient() : nullptr);

+ if (RuntimeEnabledFeatures::audioOutputDevicesEnabled())

+ provideAudioOutputDeviceClientTo(*m_frame, AudioOutputDeviceClientImpl::create());

}