third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h - Issue 1416123005: Implement setSinkId() for media elements without src.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h

Issue 1416123005: Implement setSinkId() for media elements without src. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/media/audio_output_devices/audio_output_devices-setsinkid.html ('K') | « third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.cpp ('k') | third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp » ('j') | third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h

diff --git a/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h b/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h

index 5158acc9aa77b7cef90ffed39b35e3babc3ddb2a..df83f4125c86095d475917ef759dffa0c4940df8 100644

--- a/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h

+++ b/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h

@@ -29,6 +29,7 @@ public:

void setSinkId(const String&);

private:

+ friend class SetSinkIdResolver;

Peter Beverloo 2015/11/12 16:45:42 Why do we need this?

Guido Urdaneta 2015/11/12 18:45:44 We don't. An early version of SetSinkIdResolver re

HTMLMediaElementAudioOutputDevice();

static const char* supplementName();