Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 1416123005: Implement setSinkId() for media elements without src. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebFrameClient.h
diff --git a/third_party/WebKit/public/web/WebFrameClient.h b/third_party/WebKit/public/web/WebFrameClient.h
index fd520576316b589f50d9d4fd4d2f0737b0088d9d..91fd6827227792e81ff0a57ad0616c1383e033f1 100644
--- a/third_party/WebKit/public/web/WebFrameClient.h
+++ b/third_party/WebKit/public/web/WebFrameClient.h
@@ -48,6 +48,7 @@
#include "public/platform/WebFileSystem.h"
#include "public/platform/WebFileSystemType.h"
#include "public/platform/WebSecurityOrigin.h"
+#include "public/platform/WebSetSinkIdCallbacks.h"
#include "public/platform/WebStorageQuotaCallbacks.h"
#include "public/platform/WebStorageQuotaType.h"
#include "public/platform/WebURLError.h"
@@ -674,6 +675,12 @@ public:
// WebUSB --------------------------------------------------------------
virtual WebUSBClient* usbClient() { return nullptr; }
+
+ // Audio Output Devices API --------------------------------------------
+
+ // Checks that the given audio sink exists and is authorized. The result is provided via the callback.
+ virtual void checkAudioSink(const WebString& sinkId, const WebSecurityOrigin&, WebSetSinkIdCallbacks*) { }
jochen (gone - plz use gerrit) 2015/10/28 14:18:49 why does this not just return the result? It seems
Guido Urdaneta 2015/10/28 15:58:44 It's simpler to leave the callback for two reasons
jochen (gone - plz use gerrit) 2015/10/28 16:06:47 ok, then at least postTask the callback so nobody
Guido Urdaneta 2015/10/28 17:20:10 Done. I PostTasked the whole logic, except for typ
+
protected:
virtual ~WebFrameClient() { }
};

Powered by Google App Engine
This is Rietveld 408576698