third_party/WebKit/LayoutTests/http/tests/media/audio_output_devices/setsinkid.html - Issue 1416123005: Implement setSinkId() for media elements without src.

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/media/audio_output_devices/setsinkid.html

Issue 1416123005: Implement setSinkId() for media elements without src. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More jochen's comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | third_party/WebKit/LayoutTests/media/audio_output_devices/audio_output_devices-setsinkid.html » ('j') | third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Audio Output Devices</title>

	5 <script src="../../resources/testharness.js"></script>

	6 <script src="../../resources/testharnessreport.js"></script>

	7 </head>

	8 <body>

	9 <audio id="testAudio" src="../resources/media-source/webm/test-a-128k-44100H z-1ch.webm"></audio>
	philipj_slow 2015/11/02 12:58:33 Since the individual tests change this object, I d Since the individual tests change this object, I don't think it's a good idea to share it. Better to createElement("audio") for every test and explicitly get it into the state you need for testing. Guido Urdaneta 2015/11/02 16:30:04 Done. Show quoted text On 2015/11/02 12:58:33, philipj wrote: > Since the individual tests change this object, I don't think it's a good idea to > share it. Better to createElement("audio") for every test and explicitly get it > into the state you need for testing. Done.
	10 <script>

	11 var audio = document.getElementById('testAudio');

	12

	13 // Tests that the API is available.

	14 test(function() {

	15 assert_not_equals(audio, null);

	16 assert_idl_attribute(audio, 'setSinkId');

	17 assert_equals(typeof audio.setSinkId, 'function');

	18 assert_idl_attribute(audio, 'sinkId');

	19 assert_equals(audio.sinkId, '');

	20 }, 'Basic API test');

	21

	22 // Tests that setting the sink to the default device succeeds

	23 promise_test(function() {

	24 return audio.setSinkId('')

	25 .then(function() {

	26 // do nothing
	philipj_slow 2015/11/02 12:58:33 Looking at the definition of promise_test(), it lo Looking at the definition of promise_test(), it looks like you can just return audio.setSinkId(''), as both then() and catch() are hooked up in the harness. You can do the same for any test that expects the promise to resolve. Guido Urdaneta 2015/11/02 16:30:04 Done. Show quoted text On 2015/11/02 12:58:33, philipj wrote: > Looking at the definition of promise_test(), it looks like you can just return > audio.setSinkId(''), as both then() and catch() are hooked up in the harness. > You can do the same for any test that expects the promise to resolve. Done.
	27 }).catch(function() {

	28 assert_unreached('setSinkId() should have succeeded');

	29 });

	30 }, 'setSinkId("")');

	31

	32 // Tests that setting the sink to a valid device without permission fails

	33 // Note: 'default' is the hashed name Chrome always provides for the default

	34 // device. It is treated like any other hashed device ID, so it is not

	35 // automatically authorized like ''.

	36 promise_test(function() {
	philipj_slow 2015/11/02 12:58:33 Looks like you can use promise_rejects(function() Looks like you can use promise_rejects(function() { ... }, ) for this and similar tests. Here's an example of how to use it: https://github.com/w3c/web-platform-tests/pull/1490/files Guido Urdaneta 2015/11/02 16:30:04 Done. Show quoted text On 2015/11/02 12:58:33, philipj wrote: > Looks like you can use promise_rejects(function() { ... }, ) for this and > similar tests. Here's an example of how to use it: > https://github.com/w3c/web-platform-tests/pull/1490/files Done.
	37 return audio.setSinkId('default')

	38 .then(function() {

	39 assert_unreached('setSinkId() should have failed');

	40 }).catch(function(error) {

	41 assert_equals(error.name, 'SecurityError');

	42 return Promise.resolve();

	43 });

	44 }, 'setSinkId("default") without permission' );

	45

	46 // Test that setting the sink to an invalid device fails

	47 promise_test(function() {

	48 return audio.setSinkId('invalid')

	49 .then(function() {

	50 assert_unreached('setSinkId() should have failed');

	51 }).catch(function(error) {

	52 assert_equals(error.name, 'NotFoundError');

	53 return Promise.resolve();

	54 });

	55 }, 'setSinkId("invalid")');

	56

	57 // Test that setting the sink on an element without src succeeds

	58 promise_test(function() {

	59 audio.src=""
	philipj_slow 2015/11/02 12:58:33 I think it would be better to test this with a new I think it would be better to test this with a new audio element that has never had a src attribute. If there's value in also testing this case, a separate test would be good. Guido Urdaneta 2015/11/02 16:30:04 Done. Show quoted text On 2015/11/02 12:58:33, philipj wrote: > I think it would be better to test this with a new audio element that has never > had a src attribute. If there's value in also testing this case, a separate test > would be good. Done.
	60 return audio.setSinkId('')

	61 .then(function() {

	62 // do nothing

	63 }).catch(function() {

	64 assert_unreached('setSinkId() should have succeeded');

	65 });

	66 }, 'empty src setSinkId("")');

	67

	68 // Test that setting the src of an element, and then changing the sink

	69 // both succeed.

	70 promise_test(function() {

	71 audio.src="../resources/media-source/webm/test-a-192k-44100Hz-1ch.webm"

	72 return audio.setSinkId('')

	73 .then(function() {

	74 // do nothing

	75 }).catch(function() {

	76 assert_unreached('setSinkId() should have succeeded');

	77 });

	78 }, 'new src setSinkId("")');

	79

	80 // Tests that setting the sink to the default device a second time succeeds

	81 promise_test(function() {

	82 return audio.setSinkId('')

	83 .then(function() {

	84 // do nothing

	85 }).catch(function() {

	86 assert_unreached('setSinkId() should have succeeded');

	87 });

	88 }, 'setSinkId("") 2');

	89 </script>

	90 </body>

	91 </html>

	92

OLD	NEW