Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1416123003: Fix visualbench exiting on startup on android (Closed)

Created:
5 years, 1 month ago by joshua.litt
Modified:
5 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix visualbench exiting on startup on android BUG=skia: Committed: https://skia.googlesource.com/skia/+/6db78d74fab9b285e7d4b4ae54ad278420596e8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M platform_tools/android/apps/visualbench/src/main/jni/SkOSWindow_AndroidNative.cpp View 2 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
joshualitt
5 years, 1 month ago (2015-10-26 18:47:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416123003/1
5 years, 1 month ago (2015-10-26 18:47:37 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-10-26 18:47:37 UTC) #5
bsalomon
5 years, 1 month ago (2015-10-26 18:58:32 UTC) #6
bsalomon
On 2015/10/26 18:58:32, bsalomon wrote: lgtm
5 years, 1 month ago (2015-10-26 18:58:41 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 19:00:45 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6db78d74fab9b285e7d4b4ae54ad278420596e8a

Powered by Google App Engine
This is Rietveld 408576698