Absolute Device Orientation API: blink implementation.

third_party/WebKit/Source/modules/device_orientation/DeviceOrientationAbsoluteController.cpp

Index: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationAbsoluteController.cpp
diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationAbsoluteController.cpp b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationAbsoluteController.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..27b458c0fd0e271314ef7cd088196dab6ce04bc0
--- /dev/null
+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationAbsoluteController.cpp
@@ -0,0 +1,71 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "modules/device_orientation/DeviceOrientationAbsoluteController.h"
+
+#include "core/dom/Document.h"
+#include "core/frame/Settings.h"
+#include "modules/device_orientation/DeviceOrientationDispatcher.h"
+
+namespace blink {
+
+DeviceOrientationAbsoluteController::DeviceOrientationAbsoluteController(Document& document)
+    : DeviceOrientationController(document)
+{
+}
+
+DeviceOrientationAbsoluteController::~DeviceOrientationAbsoluteController()
+{
+}
+
+const char* DeviceOrientationAbsoluteController::supplementName()
+{
+    return "DeviceOrientationAbsoluteController";
+}
+
+DeviceOrientationAbsoluteController& DeviceOrientationAbsoluteController::from(Document& document)
+{
+    DeviceOrientationAbsoluteController* controller = static_cast<DeviceOrientationAbsoluteController*>(WillBeHeapSupplement<Document>::from(document, supplementName()));
+    if (!controller) {
+        controller = new DeviceOrientationAbsoluteController(document);
+        WillBeHeapSupplement<Document>::provideTo(document, supplementName(), adoptPtrWillBeNoop(controller));
+    }
+    return *controller;
+}
+
+void DeviceOrientationAbsoluteController::didAddEventListener(LocalDOMWindow* window, const AtomicString& eventType)
+{
+    if (eventType != eventTypeName())
+        return;
+
+    if (document().frame()) {
+        String errorMessage;
+        if (!document().isSecureContext(errorMessage) && document().frame()->settings()->strictPowerfulFeatureRestrictions())
+            return;
+        // FIXME: add user counters as in DeviceOrientationController.

[Rick Byers, 2015/10/22 16:00:52]

Do you actually want separate use counters here?  Perhaps it's not really worth
tracking the difference between absolute and non-absolute for the purposes of
the UseCounter and RAPPOR metrics. If so you can avoid overriding this function
at all too.

If we decide we do want some measure of what fraction of device orientation
usage is absolute vs. non-absolute, that would still be easy to add in
DeviceOrientationController::didAddEventListener without copying the rest of the
logic (eg. just key it off of the eventType virtual).

[timvolodine, 2015/10/27 16:38:35]

Yes, well, I think it may actually be interesting to count the usage of the
absolute/non-absolute orientation events separately. The idea is that
non-absolute orientation would be useful for VR and the absolute orientation for
AR applications.

I could refactor the common bits into the base class, but the logging would be
different anyway and I didn't want to pollute the existing counters..

[Rick Byers, 2015/10/27 18:35:07]

Ok.  Adding the UseCounter should be trivial.  If it's interesting to have, why
not just do it now?  The rappor logging may be more involved (I'm not familiar
with the code changes required for that), I'm fine with a FIXME there.

[timvolodine, 2015/10/28 17:48:08]

Done. (rappor logging is a todo).

+    }
+
+    // FIXME: add rappor url logging as in DeviceOrientationController.
+
+    DeviceSingleWindowEventController::didAddEventListener(window, eventType);
+}
+
+DeviceOrientationDispatcher& DeviceOrientationAbsoluteController::dispatcherInstance() const
+{
+    return DeviceOrientationDispatcher::instance<true>();
+}
+
+const AtomicString& DeviceOrientationAbsoluteController::eventTypeName() const
+{
+    return EventTypeNames::deviceorientationabsolute;
+}
+
+DEFINE_TRACE(DeviceOrientationAbsoluteController)
+{
+    DeviceOrientationController::trace(visitor);
+    WillBeHeapSupplement<Document>::trace(visitor);
+}
+
+} // namespace blink