Absolute Device Orientation API: blink implementation.

third_party/WebKit/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "modules/device_orientation/DeviceOrientationDispatcher.h"
 
 #include "modules/device_orientation/DeviceOrientationController.h"
 #include "modules/device_orientation/DeviceOrientationData.h"
 #include "public/platform/Platform.h"
 
+namespace {
+
+blink::WebPlatformEventType getWebPlatformEventType(bool absolute)

[Rick Byers, 2015/10/22 16:00:52]

nit: make this a private const method of the class then you can just read
m_absolute rather than having to pass it in explicitly.

[timvolodine, 2015/10/27 16:38:35]

Done.

+{
+    return (absolute) ? blink::WebPlatformEventTypeDeviceOrientationAbsolute : blink::WebPlatformEventTypeDeviceOrientation;
+}
+
+} // namespace
+
 namespace blink {
 
-DeviceOrientationDispatcher& DeviceOrientationDispatcher::instance()
+template<>
+DeviceOrientationDispatcher& DeviceOrientationDispatcher::instance<true>()
 {
-    DEFINE_STATIC_LOCAL(Persistent<DeviceOrientationDispatcher>, deviceOrientationDispatcher, (new DeviceOrientationDispatcher()));
+    DEFINE_STATIC_LOCAL(Persistent<DeviceOrientationDispatcher>, deviceOrientationAbsoluteDispatcher, (new DeviceOrientationDispatcher(true)));

[Rick Byers, 2015/10/22 16:00:52]

rather than use template specialization here, wouldn't it be simpler to just
take the bool as an argument to instance and have two DEFINE_STATIC_LOCALs in
that one function?  Then just return one or the other depending on the argument.

[timvolodine, 2015/10/27 16:38:35]

yes, looks like using a template is a bit of overkill here ;)
Done.

+    return *deviceOrientationAbsoluteDispatcher;
+}
+
+template<>
+DeviceOrientationDispatcher& DeviceOrientationDispatcher::instance<false>()
+{
+    DEFINE_STATIC_LOCAL(Persistent<DeviceOrientationDispatcher>, deviceOrientationDispatcher, (new DeviceOrientationDispatcher(false)));
     return *deviceOrientationDispatcher;
 }
 
-DeviceOrientationDispatcher::DeviceOrientationDispatcher()
+DeviceOrientationDispatcher::DeviceOrientationDispatcher(bool absolute) : m_absolute(absolute)
 {
 }
 
 DeviceOrientationDispatcher::~DeviceOrientationDispatcher()
 {
 }
 
 DEFINE_TRACE(DeviceOrientationDispatcher)
 {
     visitor->trace(m_lastDeviceOrientationData);
     PlatformEventDispatcher::trace(visitor);
 }
 
 void DeviceOrientationDispatcher::startListening()
 {
-    Platform::current()->startListening(WebPlatformEventTypeDeviceOrientation, this);
+    Platform::current()->startListening(getWebPlatformEventType(m_absolute), this);
 }
 
 void DeviceOrientationDispatcher::stopListening()
 {
-    Platform::current()->stopListening(WebPlatformEventTypeDeviceOrientation);
+    Platform::current()->stopListening(getWebPlatformEventType(m_absolute));
     m_lastDeviceOrientationData.clear();
 }
 
 void DeviceOrientationDispatcher::didChangeDeviceOrientation(const WebDeviceOrientationData& motion)
 {
     m_lastDeviceOrientationData = DeviceOrientationData::create(motion);
     notifyControllers();
 }
 
 DeviceOrientationData* DeviceOrientationDispatcher::latestDeviceOrientationData()
 {
     return m_lastDeviceOrientationData.get();
 }
 
 } // namespace blink