Absolute Device Orientation API: blink implementation.

third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 36 matching lines @@
 #include "core/layout/HitTestResult.h"
 #include "core/loader/DocumentLoader.h"
 #include "core/loader/FrameLoadRequest.h"
 #include "core/loader/FrameLoader.h"
 #include "core/loader/HistoryItem.h"
 #include "core/page/Page.h"
 #include "core/page/WindowFeatures.h"
 #include "modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h"
 #include "modules/device_light/DeviceLightController.h"
 #include "modules/device_orientation/DeviceMotionController.h"
+#include "modules/device_orientation/DeviceOrientationAbsoluteController.h"
 #include "modules/device_orientation/DeviceOrientationController.h"
 #include "modules/encryptedmedia/HTMLMediaElementEncryptedMedia.h"
 #include "modules/gamepad/NavigatorGamepad.h"
 #include "modules/mediasession/MediaSession.h"
 #include "modules/serviceworkers/NavigatorServiceWorker.h"
 #include "modules/storage/DOMWindowStorageController.h"
 #include "modules/vr/NavigatorVRDevice.h"
 #include "platform/MIMETypeRegistry.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/UserGestureIndicator.h"
@@ skipping 65 matching lines @@
 }
 
 void FrameLoaderClientImpl::dispatchDidClearWindowObjectInMainWorld()
 {
     if (m_webFrame->client()) {
         m_webFrame->client()->didClearWindowObject(m_webFrame);
         Document* document = m_webFrame->frame()->document();
         if (document) {
             DeviceMotionController::from(*document);
             DeviceOrientationController::from(*document);
+            if (RuntimeEnabledFeatures::deviceOrientationAbsoluteEnabled())
+                DeviceOrientationAbsoluteController::from(*document);

[haraken, 2015/10/29 14:15:11]

If the runtime flag is enabled, won't it happen that the same object is
double-registered to the Document's supplement map?

It will cause a problem because when the Document dies, the Document calls
destructors for all supplement objects in the map. If the same object is
double-registered, the second destructor call will cause double-free.

That's why I'm concerned about implementing supplementName() on multiple classes
in the same hierarchy.

[timvolodine, 2015/10/29 19:34:33]

If understand correctly the point about supplementName() is that we are actually
hiding the super class methods. If somebody static_casts the 'absolute'
controller to its super class and then invokes supplementName() it would give
the name of the super class.

However I don't see this kind of usage in current code and don't think it's
possible to have the same object twice in the map.

If having a supplementName as part of class is a concern perhaps a solution
could be to put it into anonymous namespace in the .cpp... or extract a common
DeviceOrientationBase class and make the others derive from it while
implementing static methods. wdyt?

             if (RuntimeEnabledFeatures::deviceLightEnabled())
                 DeviceLightController::from(*document);
             NavigatorGamepad::from(*document);
             NavigatorServiceWorker::from(*document);
             DOMWindowStorageController::from(*document);
             if (RuntimeEnabledFeatures::webVREnabled())
                 NavigatorVRDevice::from(*document);
         }
     }
     // FIXME: when extensions go out of process, this whole concept stops working.
@@ skipping 814 matching lines @@
 
 void FrameLoaderClientImpl::suddenTerminationDisablerChanged(bool present, SuddenTerminationDisablerType type)
 {
     if (m_webFrame->client()) {
         m_webFrame->client()->suddenTerminationDisablerChanged(
             present, static_cast<WebFrameClient::SuddenTerminationDisablerType>(type));
     }
 }
 
 } // namespace blink