Absolute Device Orientation API: blink implementation.

third_party/WebKit/Source/modules/device_orientation/DeviceOrientationAbsoluteController.cpp

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "modules/device_orientation/DeviceOrientationAbsoluteController.h"
+
+#include "core/dom/Document.h"
+#include "core/frame/Settings.h"
+#include "modules/device_orientation/DeviceOrientationDispatcher.h"
+
+namespace blink {
+
+DeviceOrientationAbsoluteController::DeviceOrientationAbsoluteController(Document& document)
+    : DeviceOrientationController(document)
+{
+}
+
+DeviceOrientationAbsoluteController::~DeviceOrientationAbsoluteController()
+{
+}
+
+const char* DeviceOrientationAbsoluteController::supplementName()
+{
+    return "DeviceOrientationAbsoluteController";
+}
+
+DeviceOrientationAbsoluteController& DeviceOrientationAbsoluteController::from(Document& document)

[haraken, 2015/10/28 18:23:34]

I think this method should just redirect to DeviceOrientationController::from.
Then you can remove DeviceOrientationAbsoluteController::supplementName().

Basically it looks strange that you have to define supplementName() in multiple
classes in one hierarchy.

class A : public HeapSupplement<Document> {
  const char* supplementName();
};

class B : public A {
  const char* supplementName();  // This doesn't make much sense. Since A and B
are the same object, it is enough to define A::supplementName() and call
Document::provideTo() only in A::from().
};

[timvolodine, 2015/10/29 13:49:18]

Hmm, not sure how this would work. The problem is that
DeviceOrientationController and DeviceOrientationAbsoluteController can both be
supplements of the same document at the same time, so I guess we really need a
different supplement name for this to work..

+{
+    DeviceOrientationAbsoluteController* controller = static_cast<DeviceOrientationAbsoluteController*>(WillBeHeapSupplement<Document>::from(document, supplementName()));
+    if (!controller) {
+        controller = new DeviceOrientationAbsoluteController(document);
+        WillBeHeapSupplement<Document>::provideTo(document, supplementName(), adoptPtrWillBeNoop(controller));
+    }
+    return *controller;
+}
+
+void DeviceOrientationAbsoluteController::didAddEventListener(LocalDOMWindow* window, const AtomicString& eventType)
+{
+    if (eventType != eventTypeName())
+        return;
+
+    if (document().frame()) {
+        String errorMessage;
+        if (document().isSecureContext(errorMessage)) {
+            UseCounter::count(document().frame(), UseCounter::DeviceOrientationAbsoluteSecureOrigin);
+        } else {
+            UseCounter::countDeprecation(document().frame(), UseCounter::DeviceOrientationAbsoluteInsecureOrigin);
+            // FIXME: add rappor logging of insecure origins as in DeviceOrientationController.

[haraken, 2015/10/28 18:18:37]

FIXME => TODO

[timvolodine, 2015/10/29 13:49:18]

Done.

+            if (document().frame()->settings()->strictPowerfulFeatureRestrictions())
+                return;
+        }
+    }
+
+    // FIXME: add rappor url logging as in DeviceOrientationController.

[haraken, 2015/10/28 18:18:37]

FIXME => TODO

[timvolodine, 2015/10/29 13:49:18]

Done.

+
+    DeviceSingleWindowEventController::didAddEventListener(window, eventType);
+}
+
+DeviceOrientationDispatcher& DeviceOrientationAbsoluteController::dispatcherInstance() const
+{
+    return DeviceOrientationDispatcher::instance(true);
+}
+
+const AtomicString& DeviceOrientationAbsoluteController::eventTypeName() const
+{
+    return EventTypeNames::deviceorientationabsolute;
+}
+
+DEFINE_TRACE(DeviceOrientationAbsoluteController)
+{
+    DeviceOrientationController::trace(visitor);
+    WillBeHeapSupplement<Document>::trace(visitor);

[haraken, 2015/10/28 18:18:37]

This is not needed. DeviceOrientationAbsoluteController does not (directly)
inherit from WillBeHeapSupplement<Document>.

[timvolodine, 2015/10/29 13:49:18]

Done.

+}
+
+} // namespace blink