Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2292)

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 1416113012: Save-Page-As-Complete-HTML: Better handling of <object> elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@multi-frame-tests
Patch Set: Rebasing... Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/savable_resources.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/save_page_browsertest.cc
diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc
index 0c220e49ef0885318bc8536aaacedf378aac0e6c..993813c4a256b5ffc766a334a68c0f50136bac7e 100644
--- a/chrome/browser/download/save_page_browsertest.cc
+++ b/chrome/browser/download/save_page_browsertest.cc
@@ -1005,7 +1005,7 @@ IN_PROC_BROWSER_TEST_P(SavePageMultiFrameBrowserTest, CrossSite) {
}
// Test for crbug.com/553478.
-IN_PROC_BROWSER_TEST_P(SavePageMultiFrameBrowserTest, DISABLED_ObjectElements) {
+IN_PROC_BROWSER_TEST_P(SavePageMultiFrameBrowserTest, ObjectElements) {
content::SavePageType save_page_type = GetParam();
// 4 = main frame + iframe + object w/ html doc + object w/ pdf doc
@@ -1021,6 +1021,10 @@ IN_PROC_BROWSER_TEST_P(SavePageMultiFrameBrowserTest, DISABLED_ObjectElements) {
GURL url(
embedded_test_server()->GetURL("a.com", "/save_page/frames-objects.htm"));
+ // TODO(lukasza): crbug.com/553478: Enable <object> testing of MHTML.
+ if (save_page_type == content::SAVE_PAGE_TYPE_AS_MHTML)
+ return;
+
TestMultiFramePage(save_page_type, url, expected_number_of_frames,
expected_substrings);
}
« no previous file with comments | « no previous file | content/renderer/savable_resources.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698