Issue 1416113010: Merge to XFA: Remove CFX_PtrArray usage in fpdfsdk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1416113010: Merge to XFA: Remove CFX_PtrArray usage in fpdfsdk. (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Remove CFX_PtrArray usage in fpdfsdk. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1430213002 . (cherry picked from commit 8deeacd23872ecc132a0a678e344a018b5114a3a) Committed: https://pdfium.googlesource.com/pdfium/+/d88a364c1c79b294b980c20ebc9356ea42635bff

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+569 lines, -895 lines)			Patch
M	core/include/fpdfdoc/fpdf_doc.h	View	14 chunks	+28 lines, -22 lines	0 comments	Download
M	core/src/fpdfdoc/doc_action.cpp	View	2 chunks	+22 lines, -20 lines	0 comments	Download
M	core/src/fpdfdoc/doc_form.cpp	View	10 chunks	+76 lines, -97 lines	0 comments	Download
M	fpdfsdk/include/fsdk_baseform.h	View	2 chunks	+8 lines, -5 lines	0 comments	Download
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/fsdk_baseform.cpp	View	8 chunks	+59 lines, -107 lines	0 comments	Download
M	fpdfsdk/src/javascript/Document.cpp	View	5 chunks	+47 lines, -52 lines	0 comments	Download
M	fpdfsdk/src/javascript/Field.h	View	6 chunks	+7 lines, -11 lines	0 comments	Download
M	fpdfsdk/src/javascript/Field.cpp	View	88 chunks	+307 lines, -569 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	3 chunks	+9 lines, -10 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

TBR, easy to resolve XFA conflicts in fpdfsdk/include/jsapi/fxjs_v8.h and fpdfsdk/src/javascript/Document.cpp

5 years, 1 month ago (2015-11-10 17:38:51 UTC) #1

Lei Zhang

5 years, 1 month ago (2015-11-10 17:39:05 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d88a364c1c79b294b980c20ebc9356ea42635bff (presubmit successful).