Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1416113006: Minor cleanup of clip mask manager (Closed)

Created:
5 years, 1 month ago by robertphillips
Modified:
5 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Minor cleanup of clip mask manager Follow up to https://codereview.chromium.org/1418073005/ (Remove gpu-side clip mask merging from clip mask manager). The path renderer chain is only ever allocated when it is about to be used (so the delayed initialization doesn't buy us anything). We can now reduce the lifetime of the pipelineBuilder in createAlphaClipMask Committed: https://skia.googlesource.com/skia/+/13391dd97209f36c71bc18cc75084f74c2f6af15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -64 lines) Patch
M src/gpu/GrClipMaskManager.cpp View 2 chunks +23 lines, -20 lines 0 comments Download
M src/gpu/GrDrawingManager.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrPathRendererChain.h View 3 chunks +2 lines, -15 lines 0 comments Download
M src/gpu/GrPathRendererChain.cpp View 4 chunks +15 lines, -27 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
5 years, 1 month ago (2015-10-29 19:47:19 UTC) #5
bsalomon
lgtm
5 years, 1 month ago (2015-10-29 19:55:18 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416113006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416113006/1
5 years, 1 month ago (2015-10-29 19:56:16 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-29 20:09:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416113006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416113006/1
5 years, 1 month ago (2015-10-30 12:14:26 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 12:15:16 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/13391dd97209f36c71bc18cc75084f74c2f6af15

Powered by Google App Engine
This is Rietveld 408576698