Issue 14161008: [net/dns] Test IPv6 support via UDP connect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14161008: [net/dns] Test IPv6 support via UDP connect (Closed)

Created:
7 years, 8 months ago by szym

Modified:
7 years, 8 months ago

Reviewers:
mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[net/dns] Test IPv6 support via UDP connect After this CL, the effective address family will be determined by the UDP connect test rather than the last interface enumeration probe. BUG=223876 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195406

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -22 lines)			Patch
	M	net/dns/host_resolver_impl.cc	View	1	1 chunk	+23 lines, -22 lines	0 comments	Download

Total messages: 6 (0 generated)

szym

Switching to UDP-connect for real. I realized that we should only compare to default_address_family_ if ...

7 years, 8 months ago (2013-04-17 17:54:38 UTC) #1

mmenke

On 2013/04/20 01:02:05, szym wrote: > ping? I'm sorry - forgot about this one. LGTM.

7 years, 8 months ago (2013-04-20 03:39:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/14161008/1

7 years, 8 months ago (2013-04-20 03:41:35 UTC) #4

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 8 months ago (2013-04-20 03:54:59 UTC) #5

szym

7 years, 8 months ago (2013-04-21 01:26:22 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r195406 (presubmit successful).