Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 14161007: Change 'Parse error' to three more informative messages. (Closed)

Created:
7 years, 8 months ago by johnjbarton
Modified:
7 years, 8 months ago
Reviewers:
mvstanton, Sven Panne
Base URL:
https://chromium.googlesource.com/external/v8.git@master
Visibility:
Public.

Description

Change 'Parse error' to three more informative messages. Replace the 'unable_to_parse' key used in three places with three difference keys. Provide three more informative and less ambiguous error messages in place of 'Parse error'. Add three test/message cases to cover the new messages. BUG=2636 Committed: https://code.google.com/p/v8/source/detail?r=14462

Patch Set 1 #

Patch Set 2 : Line up messages #

Patch Set 3 : Add 3 test cases to test/message to cover new messages #

Patch Set 4 : git cl upload should be run with --no-find-copies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -4 lines) Patch
M src/messages.js View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/parser.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8natives.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
A test/message/isvar.js View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
A test/message/isvar.out View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A test/message/paren_in_arg_string.js View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
A test/message/paren_in_arg_string.out View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A test/message/single-function-literal.js View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A test/message/single-function-literal.out View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
johnjbarton
I did not add tests...can you point me to where the parse errors are tested?
7 years, 8 months ago (2013-04-17 17:36:26 UTC) #1
mvstanton
On 2013/04/17 17:36:26, johnjbarton wrote: > I did not add tests...can you point me to ...
7 years, 8 months ago (2013-04-22 12:32:30 UTC) #2
johnjbarton
On 2013/04/22 12:32:30, mvstanton wrote: > Looks like the right place to add a test ...
7 years, 8 months ago (2013-04-22 15:17:55 UTC) #3
johnjbarton
Ok, ready for review
7 years, 8 months ago (2013-04-25 17:19:43 UTC) #4
mvstanton
lgtm. I'll submit the patch...
7 years, 8 months ago (2013-04-26 14:25:33 UTC) #5
mvstanton
7 years, 8 months ago (2013-04-26 14:27:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r14462 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698