Issue 14161006: Fix NOTREACHED triggered by MenuItemView::GetAcceleratorText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14161006: Fix NOTREACHED triggered by MenuItemView::GetAcceleratorText (Closed)

Created:
7 years, 8 months ago by dmazzoni

Modified:
7 years, 8 months ago

Reviewers:
sadrul

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix NOTREACHED triggered by MenuItemView::GetAcceleratorText A recent change to accessibility on Chrome OS is triggering a call to MenuItemView::GetAccessibleState on a MenuItemView that has a delegate but no command id, which asserts in MenuModelAdapter when we try to look up a command that's not there. The fix is to not call MenuModelAdapter::GetAccelerator to look up a command when the command is zero. BUG=230107, 232079 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194665

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/views/controls/menu/menu_item_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r194665.

Expand Messages | Collapse Messages