Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1416093006: Unify setting accessor properties in native code. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Unify setting accessor properties in native code. R=cbruni@chromium.org Committed: https://crrev.com/483d8b9bd85c670a7ba355396aa535d760ba592d Cr-Commit-Position: refs/heads/master@{#31910}

Patch Set 1 #

Patch Set 2 : do not rename regexp flags getter #

Patch Set 3 : fix #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -62 lines) Patch
M src/js/harmony-regexp.js View 1 2 2 chunks +3 lines, -9 lines 0 comments Download
M src/js/messages.js View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/js/prologue.js View 1 2 1 chunk +6 lines, -7 lines 0 comments Download
M src/js/regexp.js View 1 2 3 2 chunks +27 lines, -33 lines 0 comments Download
M test/mjsunit/es6/regexp-flags.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/test262/test262.status View 1 2 3 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Yang
5 years, 1 month ago (2015-11-05 11:51:07 UTC) #1
Camillo Bruni
lgtm
5 years, 1 month ago (2015-11-05 12:03:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416093006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416093006/1
5 years, 1 month ago (2015-11-05 12:03:27 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/9850)
5 years, 1 month ago (2015-11-05 12:14:31 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416093006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416093006/20001
5 years, 1 month ago (2015-11-05 12:23:13 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/9809)
5 years, 1 month ago (2015-11-05 12:38:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416093006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416093006/40001
5 years, 1 month ago (2015-11-09 10:21:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416093006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416093006/60001
5 years, 1 month ago (2015-11-10 06:38:19 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-10 06:58:11 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 06:58:53 UTC) #19
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/483d8b9bd85c670a7ba355396aa535d760ba592d
Cr-Commit-Position: refs/heads/master@{#31910}

Powered by Google App Engine
This is Rietveld 408576698