Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1416053007: Introduce LookupIterator::Restart() and use it (Closed)

Created:
5 years, 2 months ago by Jakob Kummerow
Modified:
5 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce LookupIterator::Restart() and use it Committed: https://crrev.com/5676415b4add059b78f98a9a762d00c8d721dbcd Cr-Commit-Position: refs/heads/master@{#31483}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M src/lookup.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/lookup.cc View 1 chunk +3 lines, -3 lines 1 comment Download
M src/objects.cc View 1 8 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jakob Kummerow
PTAL. I hope you'll enjoy the s/o/object/ renaming :-) https://codereview.chromium.org/1416053007/diff/20001/src/lookup.cc File src/lookup.cc (right): https://codereview.chromium.org/1416053007/diff/20001/src/lookup.cc#newcode89 src/lookup.cc:89: ...
5 years, 2 months ago (2015-10-22 15:33:25 UTC) #2
Toon Verwaest
lgtm
5 years, 2 months ago (2015-10-22 16:05:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416053007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416053007/20001
5 years, 2 months ago (2015-10-22 16:07:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-22 16:31:22 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5676415b4add059b78f98a9a762d00c8d721dbcd Cr-Commit-Position: refs/heads/master@{#31483}
5 years, 2 months ago (2015-10-22 16:31:52 UTC) #7
Michael Hablich
5 years, 2 months ago (2015-10-23 19:21:21 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1418213003/ by hablich@chromium.org.

The reason for reverting is: Breaks test if rolled into Chromium:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20...

Needed so the reverts applies cleanly and seems to be related to the offending
CL..

Powered by Google App Engine
This is Rietveld 408576698