Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 1416053003: Let synchronized painting generate correct paint invalidation rects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: For landing Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
index e2b56bff44a3626f445b63f3687f7c2846d42391..71dc55748fd502afa5e8da57fa7b492670a8e521 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
@@ -220,8 +220,6 @@ void PaintLayerScrollableArea::invalidateScrollbarRect(Scrollbar* scrollbar, con
if (scrollRect.isEmpty())
return;
- box().invalidateDisplayItemClient(*scrollbar);
-
LayoutRect paintInvalidationRect = LayoutRect(scrollRect);
box().flipForWritingMode(paintInvalidationRect);
@@ -235,6 +233,7 @@ void PaintLayerScrollableArea::invalidateScrollbarRect(Scrollbar* scrollbar, con
// We have invalidated the displayItemClient of the scrollbar, but for now we still need to
// invalidate the rectangles to trigger repaints.
box().invalidatePaintRectangleNotInvalidatingDisplayItemClients(LayoutRect(intRect));
+ box().invalidateDisplayItemClient(*scrollbar);
}
}
@@ -1567,8 +1566,10 @@ void PaintLayerScrollableArea::ScrollbarManager::destroyScrollbar(ScrollbarOrien
if (!scrollbar)
return;
- if (invalidate)
+ if (invalidate) {
+ m_scrollableArea->box().invalidateDisplayItemClient(*scrollbar);
scrollbar->invalidate();
+ }
if (!scrollbar->isCustomScrollbar())
m_scrollableArea->willRemoveScrollbar(scrollbar.get(), orientation);
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698