third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 1416053003: Let synchronized painting generate correct paint invalidation rects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1416053003: Let synchronized painting generate correct paint invalidation rects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: For landing Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/virtual/syncpaint/paint/README.txt ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 3ccd0fb30a9abd344f1ce1e8b3ecb451c5865aa9..8b43865107c3c03ed3f4aef590f6580215115b9a 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -2518,7 +2518,7 @@ void FrameView::synchronizedPaintRecursively(GraphicsLayer* graphicsLayer, const

graphicsLayer->paintIfNeeded(context);

if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled())

- graphicsLayer->paintController()->commitNewDisplayItems(graphicsLayer);

+ graphicsLayer->paintController()->commitNewDisplayItems();

for (auto& child : graphicsLayer->children())

synchronizedPaintRecursively(child, interestRect);

@@ -2533,7 +2533,7 @@ void FrameView::compositeForSlimmingPaintV2()

// Detached frames can have no root graphics layer.

if (GraphicsLayer* rootGraphicsLayer = layoutView()->layer()->graphicsLayerBacking())

- rootGraphicsLayer->paintController()->commitNewDisplayItems(rootGraphicsLayer);

+ rootGraphicsLayer->paintController()->commitNewDisplayItems();

forAllFrameViews([](FrameView& frameView) { frameView.lifecycle().advanceTo(DocumentLifecycle::CompositingForSlimmingPaintV2Clean); });

}