Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutText.cpp

Issue 1416053003: Let synchronized painting generate correct paint invalidation rects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: For landing Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * (C) 1999 Lars Knoll (knoll@kde.org) 2 * (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Dirk Mueller (mueller@kde.org) 3 * (C) 2000 Dirk Mueller (mueller@kde.org)
4 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net) 5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)
6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 1855 matching lines...) Expand 10 before | Expand all | Expand 10 after
1866 gSecureTextTimers->add(this, secureTextTimer); 1866 gSecureTextTimers->add(this, secureTextTimer);
1867 } 1867 }
1868 secureTextTimer->restartWithNewText(lastTypedCharacterOffset); 1868 secureTextTimer->restartWithNewText(lastTypedCharacterOffset);
1869 } 1869 }
1870 1870
1871 PassRefPtr<AbstractInlineTextBox> LayoutText::firstAbstractInlineTextBox() 1871 PassRefPtr<AbstractInlineTextBox> LayoutText::firstAbstractInlineTextBox()
1872 { 1872 {
1873 return AbstractInlineTextBox::getOrCreate(this, m_firstTextBox); 1873 return AbstractInlineTextBox::getOrCreate(this, m_firstTextBox);
1874 } 1874 }
1875 1875
1876 void LayoutText::invalidateDisplayItemClients(const LayoutBoxModelObject& paintI nvalidationContainer, PaintInvalidationReason invalidationReason, const LayoutRe ct& previousPaintInvalidationRect, const LayoutRect& newPaintInvalidationRect) c onst 1876 void LayoutText::invalidateDisplayItemClients(const LayoutBoxModelObject& paintI nvalidationContainer, PaintInvalidationReason invalidationReason, const LayoutRe ct* paintInvalidationRect) const
1877 { 1877 {
1878 LayoutObject::invalidateDisplayItemClients(paintInvalidationContainer, inval idationReason, previousPaintInvalidationRect, newPaintInvalidationRect); 1878 LayoutObject::invalidateDisplayItemClients(paintInvalidationContainer, inval idationReason, paintInvalidationRect);
1879 1879
1880 LayoutRect emptyInvalidationRect; 1880 // TODO(wangxianzhu): Pass current bounds of text boxes to PaintController. crbug.com/547119.
1881 for (InlineTextBox* box = firstTextBox(); box; box = box->nextTextBox()) { 1881 for (InlineTextBox* box = firstTextBox(); box; box = box->nextTextBox()) {
1882 paintInvalidationContainer.invalidateDisplayItemClientOnBacking(*box, in validationReason, emptyInvalidationRect, emptyInvalidationRect); 1882 paintInvalidationContainer.invalidateDisplayItemClientOnBacking(*box, in validationReason, nullptr);
1883 if (box->truncation() != cNoTruncation) { 1883 if (box->truncation() != cNoTruncation) {
1884 if (EllipsisBox* ellipsisBox = box->root().ellipsisBox()) 1884 if (EllipsisBox* ellipsisBox = box->root().ellipsisBox())
1885 paintInvalidationContainer.invalidateDisplayItemClientOnBacking( *ellipsisBox, invalidationReason, emptyInvalidationRect, emptyInvalidationRect); 1885 paintInvalidationContainer.invalidateDisplayItemClientOnBacking( *ellipsisBox, invalidationReason, nullptr);
1886 } 1886 }
1887 } 1887 }
1888 } 1888 }
1889 1889
1890 } // namespace blink 1890 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutText.h ('k') | third_party/WebKit/Source/core/layout/LayoutView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698