third_party/WebKit/Source/core/layout/LayoutInline.cpp - Issue 1416053003: Let synchronized painting generate correct paint invalidation rects

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutInline.cpp

Issue 1416053003: Let synchronized painting generate correct paint invalidation rects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: For landing Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutInline.h ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.	4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 1386 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1397 if (!container)	1397 if (!container)

1398 container = this;	1398 container = this;

1399	1399

1400 FloatPoint absPos = container->localToAbsolute();	1400 FloatPoint absPos = container->localToAbsolute();

1401 region.bounds.setX(absPos.x() + region.bounds.x());	1401 region.bounds.setX(absPos.x() + region.bounds.x());

1402 region.bounds.setY(absPos.y() + region.bounds.y());	1402 region.bounds.setY(absPos.y() + region.bounds.y());

1403	1403

1404 regions.append(region);	1404 regions.append(region);

1405 }	1405 }

1406	1406

1407 void LayoutInline::invalidateDisplayItemClients(const LayoutBoxModelObject& pain tInvalidationContainer, PaintInvalidationReason invalidationReason, const Layout Rect& previousPaintInvalidationRect, const LayoutRect& newPaintInvalidationRect) const	1407 void LayoutInline::invalidateDisplayItemClients(const LayoutBoxModelObject& pain tInvalidationContainer, PaintInvalidationReason invalidationReason, const Layout Rect* paintInvalidationRect) const

1408 {	1408 {

1409 LayoutBoxModelObject::invalidateDisplayItemClients(paintInvalidationContaine r, invalidationReason, previousPaintInvalidationRect, newPaintInvalidationRect);	1409 LayoutBoxModelObject::invalidateDisplayItemClients(paintInvalidationContaine r, invalidationReason, paintInvalidationRect);

	1410 // TODO(wangxianzhu): Pass current bounds of lineboxes to PaintController. c rbug.com/547119.

1410 for (InlineFlowBox* box = firstLineBox(); box; box = box->nextLineBox())	1411 for (InlineFlowBox* box = firstLineBox(); box; box = box->nextLineBox())

1411 paintInvalidationContainer.invalidateDisplayItemClientOnBacking(*box, in validationReason, previousPaintInvalidationRect, newPaintInvalidationRect);	1412 paintInvalidationContainer.invalidateDisplayItemClientOnBacking(*box, in validationReason, nullptr);

1412 }	1413 }

1413	1414

1414 } // namespace blink	1415 } // namespace blink

OLD	NEW