third_party/WebKit/Source/core/layout/LayoutInline.cpp - Issue 1416053003: Let synchronized painting generate correct paint invalidation rects

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutInline.cpp

Issue 1416053003: Let synchronized painting generate correct paint invalidation rects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutInline.h ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.	4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 1374 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1385 if (!container)	1385 if (!container)

1386 container = this;	1386 container = this;

1387	1387

1388 FloatPoint absPos = container->localToAbsolute();	1388 FloatPoint absPos = container->localToAbsolute();

1389 region.bounds.setX(absPos.x() + region.bounds.x());	1389 region.bounds.setX(absPos.x() + region.bounds.x());

1390 region.bounds.setY(absPos.y() + region.bounds.y());	1390 region.bounds.setY(absPos.y() + region.bounds.y());

1391	1391

1392 regions.append(region);	1392 regions.append(region);

1393 }	1393 }

1394	1394

1395 void LayoutInline::invalidateDisplayItemClients(const LayoutBoxModelObject& pain tInvalidationContainer, PaintInvalidationReason invalidationReason, const Layout Rect& previousPaintInvalidationRect, const LayoutRect& newPaintInvalidationRect) const	1395 void LayoutInline::invalidateDisplayItemClients(const LayoutBoxModelObject& pain tInvalidationContainer, PaintInvalidationReason invalidationReason, const Layout Rect* paintInvalidationRect) const

1396 {	1396 {

1397 LayoutBoxModelObject::invalidateDisplayItemClients(paintInvalidationContaine r, invalidationReason, previousPaintInvalidationRect, newPaintInvalidationRect);	1397 LayoutBoxModelObject::invalidateDisplayItemClients(paintInvalidationContaine r, invalidationReason, paintInvalidationRect);

	1398 // TODO(wangxianzhu): Pass current bounds of lineboxes to PaintController.
	chrishtr 2015/10/23 17:15:07 Please file a bug to not lose track of this. Please file a bug to not lose track of this. Xianzhu 2015/10/23 18:43:27 Done. Show quoted text On 2015/10/23 17:15:07, chrishtr wrote: > Please file a bug to not lose track of this. Done.
1398 for (InlineFlowBox* box = firstLineBox(); box; box = box->nextLineBox())	1399 for (InlineFlowBox* box = firstLineBox(); box; box = box->nextLineBox())

1399 paintInvalidationContainer.invalidateDisplayItemClientOnBacking(*box, in validationReason, previousPaintInvalidationRect, newPaintInvalidationRect);	1400 paintInvalidationContainer.invalidateDisplayItemClientOnBacking(*box, in validationReason, nullptr);

1400 }	1401 }

1401	1402

1402 } // namespace blink	1403 } // namespace blink

OLD	NEW