Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 1416043008: Hide implementation members in dart:html, dart:js and related libraries (Closed)

Created:
5 years, 1 month ago by kevmoo
Modified:
5 years, 1 month ago
Reviewers:
terry, Alan Knight, Jacob
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+616 lines, -1 line) Patch
M sdk/lib/html/dartium/html_dartium.dart View 389 chunks +391 lines, -1 line 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 11 chunks +11 lines, -0 lines 0 comments Download
M sdk/lib/js/dartium/js_dartium.dart View 4 chunks +4 lines, -0 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 137 chunks +137 lines, -0 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 27 chunks +27 lines, -0 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 34 chunks +34 lines, -0 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 5 chunks +5 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/dom/src/dartium_KeyEvent.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DOMException.darttemplate View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
kevmoo
Jacob: please review changes for dart:js – these all feel like members that shouldn't be ...
5 years, 1 month ago (2015-11-02 16:01:23 UTC) #4
terry
Thanks Kevin - LGTM
5 years, 1 month ago (2015-11-02 16:06:26 UTC) #5
Jacob
lgtm
5 years, 1 month ago (2015-11-02 17:40:51 UTC) #6
Alan Knight
lgtm https://codereview.chromium.org/1416043008/diff/1/tools/dom/templates/html/impl/impl_DOMException.darttemplate File tools/dom/templates/html/impl/impl_DOMException.darttemplate (right): https://codereview.chromium.org/1416043008/diff/1/tools/dom/templates/html/impl/impl_DOMException.darttemplate#newcode55 tools/dom/templates/html/impl/impl_DOMException.darttemplate:55: @Deprecated("Internal Use Only") This field should just be ...
5 years, 1 month ago (2015-11-02 17:57:21 UTC) #7
kevmoo
5 years, 1 month ago (2015-11-02 18:23:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
156bc53866492316154278538b8395dd12afc890 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698