Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1416043005: Support multiple contexts in command_buffer_gles2 (Closed)

Created:
5 years, 1 month ago by Kimmo Kinnunen
Modified:
5 years, 1 month ago
Reviewers:
hendrikw, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support multiple contexts in command_buffer_gles2 Fix problems with multiple contexts when using command_buffer_gles2 library. Rendering to two different command_buffer_gles2-provided contexts would not work, as the last created native context would remain current. Also fixes a problem with Skia, where Skia would create and use a GLX context directly, as well as using command_buffer_gles2 context. BUG=skia:2992 Committed: https://crrev.com/213e490b733180b643600217e0fdc39e596b109a Cr-Commit-Position: refs/heads/master@{#356058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gpu/gles2_conform_support/egl/display.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
Kimmo Kinnunen
5 years, 1 month ago (2015-10-26 09:38:53 UTC) #2
piman
lgtm
5 years, 1 month ago (2015-10-26 15:59:41 UTC) #3
hendrikw
On 2015/10/26 15:59:41, piman (slow to review) wrote: > lgtm Awesome, thanks! lgtm as well.
5 years, 1 month ago (2015-10-26 16:14:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416043005/1
5 years, 1 month ago (2015-10-26 16:15:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 16:26:09 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 16:27:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/213e490b733180b643600217e0fdc39e596b109a
Cr-Commit-Position: refs/heads/master@{#356058}

Powered by Google App Engine
This is Rietveld 408576698