Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

Issue 1416043002: Revert "Use DOMSettableTokenList for {HTMLAnchorElement, HTMLAreaElement}.ping." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp b/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
index 1ce328a8a551d2b31060e802e36da5f33142a76d..91bd2ff4a9b1a0607470be8f65f5a70b9df4f40b 100644
--- a/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
@@ -53,13 +53,6 @@ HTMLAnchorElement::HTMLAnchorElement(const QualifiedName& tagName, Document& doc
{
}
-DEFINE_TRACE(HTMLAnchorElement)
-{
- visitor->trace(m_ping);
- HTMLElement::trace(visitor);
- DOMSettableTokenListObserver::trace(visitor);
-}
-
PassRefPtrWillBeRawPtr<HTMLAnchorElement> HTMLAnchorElement::create(Document& document)
{
return adoptRefWillBeNoop(new HTMLAnchorElement(aTag, document));
@@ -67,10 +60,6 @@ PassRefPtrWillBeRawPtr<HTMLAnchorElement> HTMLAnchorElement::create(Document& do
HTMLAnchorElement::~HTMLAnchorElement()
{
-#if !ENABLE(OILPAN)
- if (m_ping)
- m_ping->setObserver(nullptr);
-#endif
}
bool HTMLAnchorElement::supportsFocus() const
@@ -231,8 +220,6 @@ void HTMLAnchorElement::parseAttribute(const QualifiedName& name, const AtomicSt
// Do nothing.
} else if (name == relAttr) {
setRel(value);
- } else if (name == pingAttr) {
- ping()->setValue(value);
} else {
HTMLElement::parseAttribute(name, value);
}
@@ -333,24 +320,17 @@ bool HTMLAnchorElement::isLiveLink() const
void HTMLAnchorElement::sendPings(const KURL& destinationURL) const
{
- if (!m_ping || m_ping->value().isNull() || !document().settings() || !document().settings()->hyperlinkAuditingEnabled())
+ const AtomicString& pingValue = getAttribute(pingAttr);
+ if (pingValue.isNull() || !document().settings() || !document().settings()->hyperlinkAuditingEnabled())
return;
UseCounter::count(document(), UseCounter::HTMLAnchorElementPingAttribute);
- const SpaceSplitString& pingURLs = m_ping->tokens();
+ SpaceSplitString pingURLs(pingValue, SpaceSplitString::ShouldNotFoldCase);
for (unsigned i = 0; i < pingURLs.size(); i++)
PingLoader::sendLinkAuditPing(document().frame(), document().completeURL(pingURLs[i]), destinationURL);
}
-DOMSettableTokenList* HTMLAnchorElement::ping()
-{
- if (!m_ping)
- m_ping = DOMSettableTokenList::create(this);
-
- return m_ping.get();
-}
-
void HTMLAnchorElement::handleClick(Event* event)
{
event->setDefaultHandled();
@@ -393,11 +373,6 @@ void HTMLAnchorElement::handleClick(Event* event)
}
}
-void HTMLAnchorElement::valueChanged()
-{
- setSynchronizedLazyAttribute(pingAttr, m_ping->value());
-}
-
bool isEnterKeyKeydownEvent(Event* event)
{
return event->type() == EventTypeNames::keydown && event->isKeyboardEvent() && toKeyboardEvent(event)->keyIdentifier() == "Enter";
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLAnchorElement.h ('k') | third_party/WebKit/Source/core/html/HTMLAnchorElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698