Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1416033004: Fix reference to non-existent MSVS version (Closed)

Created:
5 years, 1 month ago by brucedawson
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix reference to non-existent MSVS version MSVS2014 does not exist. MSVS2013 has the bugs with raw string literals. They might work in MSVS2015 - we'll see. R=thakis@chromium.org Committed: https://crrev.com/d174d80cb30cee65e0cfd4c1a27647c7a814afa5 Cr-Commit-Position: refs/heads/master@{#358358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M styleguide/c++/c++11.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
brucedawson
Trivial style guide bug fix - could help avoid confusion in the future.
5 years, 1 month ago (2015-11-06 18:18:03 UTC) #1
Nico
lgtm
5 years, 1 month ago (2015-11-06 18:20:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416033004/1
5 years, 1 month ago (2015-11-06 18:25:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 18:38:02 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 18:38:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d174d80cb30cee65e0cfd4c1a27647c7a814afa5
Cr-Commit-Position: refs/heads/master@{#358358}

Powered by Google App Engine
This is Rietveld 408576698