Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1416003008: Easier upload progress browser test for Mac buildbots (Closed)

Created:
5 years, 1 month ago by Charlie Harrison
Modified:
5 years, 1 month ago
Reviewers:
mmenke
CC:
chromium-reviews, loading-reviews_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac buildbots take 5-30 times longer to run these tests than the others, give them the smaller upload progress job for now. BUG=548819 Committed: https://crrev.com/591eec3d9a017ce11b7f07ad7805ac294cdee2e2 Cr-Commit-Position: refs/heads/master@{#357171}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Comment + bug link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/browser/loader/async_resource_handler_browsertest.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Charlie Harrison
Hey Matt, could you take a look at this? Thanks!
5 years, 1 month ago (2015-10-30 12:41:42 UTC) #3
mmenke
LGTM. Do wonder about why OSX is so slow here, though. https://codereview.chromium.org/1416003008/diff/20001/content/browser/loader/async_resource_handler_browsertest.cc File content/browser/loader/async_resource_handler_browsertest.cc (right): ...
5 years, 1 month ago (2015-10-30 15:35:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416003008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416003008/40001
5 years, 1 month ago (2015-10-30 18:49:06 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-10-30 19:25:01 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 19:25:50 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/591eec3d9a017ce11b7f07ad7805ac294cdee2e2
Cr-Commit-Position: refs/heads/master@{#357171}

Powered by Google App Engine
This is Rietveld 408576698