Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1632)

Unified Diff: Source/core/platform/chromium/PopupListBox.cpp

Issue 14160005: Track the region where text is painted. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase with TOT Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/platform/chromium/PopupListBox.cpp
diff --git a/Source/core/platform/chromium/PopupListBox.cpp b/Source/core/platform/chromium/PopupListBox.cpp
index da48a8f6c74ad99c8d3f105ef779b4d7cbfd0c6d..00c3662a778c81a20301e63ce18bb22a0dda70d8 100644
--- a/Source/core/platform/chromium/PopupListBox.cpp
+++ b/Source/core/platform/chromium/PopupListBox.cpp
@@ -472,7 +472,7 @@ void PopupListBox::paintRow(GraphicsContext* gc, const IntRect& rect, int rowInd
// Draw the item text.
int textY = rowRect.y() + itemFont.fontMetrics().ascent() + (rowRect.height() - itemFont.fontMetrics().height()) / 2;
- gc->drawBidiText(itemFont, textRun, IntPoint(textX, textY));
+ gc->drawBidiText(itemFont, textRun, IntPoint(textX, textY), rowRect);
// We are using the left padding as the right padding includes room for the scroll-bar which
// does not show in this case.
@@ -509,7 +509,7 @@ void PopupListBox::paintRow(GraphicsContext* gc, const IntRect& rect, int rowInd
textX = remainingWidth - itemFont.width(labelTextRun);
gc->setFillColor(labelColor, ColorSpaceDeviceRGB);
- gc->drawBidiText(itemFont, labelTextRun, IntPoint(textX, textY));
+ gc->drawBidiText(itemFont, labelTextRun, IntPoint(textX, textY), rowRect);
}
Font PopupListBox::getRowFont(int rowIndex)

Powered by Google App Engine
This is Rietveld 408576698