Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 1415993003: Generalize python_git_runner for use in non-git scripts. (Closed)

Created:
5 years, 2 months ago by Michael Moss
Modified:
5 years, 1 month ago
Reviewers:
iannucci1, iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generalize python_git_runner for use in non-git scripts. Also fixes an msys (git-bash) incompatibility, similar to the one fixed in crrev.com/4845f0ed694ff071da5f6ee937a0bce2ea4e6fd2. This change doesn't actually use the wrapper in any new places, but subsequent changes will be made to use it in places where 'exec python' is called directly, like gclient and fetch. BUG=411518 R=iannucci@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -69 lines) Patch
M git-auto-svn View 1 chunk +1 line, -1 line 0 comments Download
M git-cache View 1 chunk +1 line, -1 line 0 comments Download
M git-cherry-pick-upload View 1 chunk +1 line, -1 line 0 comments Download
M git-cl View 1 chunk +1 line, -1 line 0 comments Download
M git-drover View 1 chunk +1 line, -1 line 0 comments Download
M git-find-releases View 1 chunk +1 line, -1 line 0 comments Download
M git-footers View 1 chunk +1 line, -1 line 0 comments Download
M git-freeze View 1 chunk +1 line, -1 line 0 comments Download
M git-map View 1 chunk +1 line, -1 line 0 comments Download
M git-map-branches View 1 chunk +1 line, -1 line 0 comments Download
M git-mark-merge-base View 1 chunk +1 line, -1 line 0 comments Download
M git-nav-downstream View 1 chunk +1 line, -1 line 0 comments Download
M git-new-branch View 1 chunk +1 line, -1 line 0 comments Download
M git-number View 1 chunk +1 line, -1 line 0 comments Download
M git-rebase-update View 1 chunk +1 line, -1 line 0 comments Download
M git-rename-branch View 1 chunk +1 line, -1 line 0 comments Download
M git-reparent-branch View 1 chunk +1 line, -1 line 0 comments Download
M git-retry View 1 chunk +1 line, -1 line 0 comments Download
M git-squash-branch View 1 chunk +1 line, -1 line 0 comments Download
M git-thaw View 1 chunk +1 line, -1 line 0 comments Download
M git-try View 1 chunk +1 line, -1 line 0 comments Download
M git-upstream-diff View 1 chunk +1 line, -1 line 0 comments Download
D python_git_runner.sh View 1 chunk +0 lines, -36 lines 0 comments Download
A + python_runner.sh View 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
Michael Moss
5 years, 2 months ago (2015-10-20 23:26:59 UTC) #1
Michael Moss
ping
5 years, 2 months ago (2015-10-22 15:03:54 UTC) #2
Michael Moss
ping
5 years, 1 month ago (2015-10-27 21:43:40 UTC) #3
iannucci
On 2015/10/27 at 21:43:40, mmoss wrote: > ping Sorry, was OOO till today. Looking now.
5 years, 1 month ago (2015-10-27 22:00:12 UTC) #4
iannucci
lgtm
5 years, 1 month ago (2015-10-27 22:04:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415993003/1
5 years, 1 month ago (2015-10-28 15:04:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=297357
5 years, 1 month ago (2015-10-28 15:06:12 UTC) #9
Adrian Kuegel
On 2015/10/28 15:06:12, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
5 years, 1 month ago (2015-10-28 15:38:25 UTC) #10
Adrian Kuegel
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1414923008/ by akuegel@chromium.org. ...
5 years, 1 month ago (2015-10-28 15:41:03 UTC) #11
sky
On 2015/10/28 15:41:03, Adrian Kuegel wrote: > A revert of this CL (patchset #1 id:1) ...
5 years, 1 month ago (2015-10-28 16:12:44 UTC) #12
sky
5 years, 1 month ago (2015-10-28 16:16:09 UTC) #13
Message was sent while issue was closed.
On 2015/10/28 16:12:44, sky wrote:
> On 2015/10/28 15:41:03, Adrian Kuegel wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/1414923008/ by mailto:akuegel@chromium.org.
> > 
> > The reason for reverting is: Speculative revert in case this caused the bots
> to
> > fail bot_update..
> 
> This broke me locally. By locally I mean windows with msys. Here's the error I
> get:
> 
> $ git cl
> /c/src/depot_tools/python_runner.sh: line 35:
> d:/src/builds/build2/src/c:\src\depot_tools\git_cl.py: No such file or
directory
> /c/src/depot_tools/python_runner.sh: line 35: exec:
> d:/src/builds/build2/src/c:\src\depot_tools\git_cl.py: cannot execute: No such
> file or directory

Yep, it was this patch that caused me grief. Syncing to the revert I can now git
cl upload again.

Powered by Google App Engine
This is Rietveld 408576698