Issue 1415963003: [Contextual Search] Fix history removal regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1415963003: [Contextual Search] Fix history removal regression. (Closed)

Created:
5 years, 2 months ago by pedro (no code reviews)

Modified:
5 years, 2 months ago

Reviewers:
Donn Denman, aurimas (slooooooooow)

CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org

Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2526

Target Ref:
refs/pending/branch-heads/2526

Project:
chromium

Visibility:
Public.

[Contextual Search] Fix history removal regression. Original CL: https://codereview.chromium.org/1412423003 BUG=545617 BUG=545614 TBR=donnd@chromium.org,aurimas@chromium.org Cr-Commit-Position: refs/heads/master@{#355178} (cherry picked from commit 9978acd0c0d83d104886f035f9a85327e67722ba) Committed: https://chromium.googlesource.com/chromium/src/+/0b7b5d14848fbfac71ee25c0cbed44d2c67f4858

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java	View		3 chunks	+5 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)

pedro (no code reviews)

5 years, 2 months ago (2015-10-20 23:30:36 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0b7b5d14848fbfac71ee25c0cbed44d2c67f4858 (presubmit successful).