Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: ui/file_manager/video_player/js/video_player.js

Issue 1415953006: Fix accessibility issues in AudioPlayer and VideoPlayer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/video_player/js/video_player.js
diff --git a/ui/file_manager/video_player/js/video_player.js b/ui/file_manager/video_player/js/video_player.js
index eaa6f31cb3e336c0b298c0e1c6841a88d93b807b..ac4d88cd456abc3897e0b497fcba9e41b4095d1d 100644
--- a/ui/file_manager/video_player/js/video_player.js
+++ b/ui/file_manager/video_player/js/video_player.js
@@ -28,9 +28,9 @@ function FullWindowVideoControls(
window.addEventListener('resize', this.updateStyle.wrap(this));
var currentWindow = chrome.app.window.current();
currentWindow.onFullscreened.addListener(
- this.onFullScreenChanged_.bind(this, true));
+ this.onFullScreenChanged.bind(this, true));
currentWindow.onRestored.addListener(
- this.onFullScreenChanged_.bind(this, false));
+ this.onFullScreenChanged.bind(this, false));
document.addEventListener('keydown', function(e) {
switch (util.getKeyModifiers(e) + e.keyIdentifier) {
// Handle debug shortcut keys.
@@ -168,19 +168,6 @@ FullWindowVideoControls.prototype.toggleFullScreen_ = function() {
};
/**
- * Updates video control when the window is fullscreened or restored.
- * @param {boolean} fullscreen True if the window gets fullscreened.
- * @private
- */
-FullWindowVideoControls.prototype.onFullScreenChanged_ = function(fullscreen) {
- if (fullscreen) {
- this.playerContainer_.setAttribute('fullscreen', '');
- } else {
- this.playerContainer_.removeAttribute('fullscreen');
- }
-};
-
-/**
* Media completion handler.
*/
FullWindowVideoControls.prototype.onMediaComplete = function() {

Powered by Google App Engine
This is Rietveld 408576698