components/web_input/DEPS - Issue 1415953004: Move content/renderer input handling for web input events to ui

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/web_input/DEPS

Issue 1415953004: Move content/renderer input handling for web input events to ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Component rename. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+cc",
	danakj 2015/11/05 22:28:01 also -cc/blink Or, does this use anything except also -cc/blink Or, does this use anything except a couple headers in cc? How about just DEPSing on those? cc/input/input_handler.h cc/input/scroll_elasticity_helper.h ? Khushal 2015/11/05 22:49:49 It uses the swap promise monitor as well. Would yo Show quoted text On 2015/11/05 22:28:01, danakj wrote: > also -cc/blink > > Or, does this use anything except a couple headers in cc? How about just DEPSing > on those? > > cc/input/input_handler.h > cc/input/scroll_elasticity_helper.h ? It uses the swap promise monitor as well. Would you prefer if it had specific DEPS for the cc includes? danakj 2015/11/05 23:07:54 I kinda do, just because this area of the code has Show quoted text On 2015/11/05 22:49:49, Khushal wrote: > On 2015/11/05 22:28:01, danakj wrote: > > also -cc/blink > > > > Or, does this use anything except a couple headers in cc? How about just > DEPSing > > on those? > > > > cc/input/input_handler.h > > cc/input/scroll_elasticity_helper.h ? > > It uses the swap promise monitor as well. Would you prefer if it had specific > DEPS for the cc includes? I kinda do, just because this area of the code has grown a bunch of external APIs out of cc, and I have been pushing back against that and trying to remove them and get us down to just InputHandler (and I guess SwapPromiseMonitor). If you don't mind I'd prefer it.
	3

	4 # No inclusion of WebKit other than strictly enum/POD, header-only types.

	5 "+third_party/WebKit/public/platform/WebGestureCurve.h",

	6 "+third_party/WebKit/public/platform/WebGestureCurveTarget.h",

	7 "+third_party/WebKit/public/platform/WebFloatPoint.h",

	8 "+third_party/WebKit/public/platform/WebFloatSize.h",

	9 "+third_party/WebKit/public/platform/WebPoint.h",

	10 "+third_party/WebKit/public/web/WebActiveWheelFlingParameters.h",

	11 "+third_party/WebKit/public/web/WebInputEvent.h",

	12

	13 "+ui/gfx",
	danakj 2015/11/05 22:29:16 do you need all gfx? or just geometry? do you need all gfx? or just geometry? Khushal 2015/11/05 22:49:49 Just geometry. Done. Show quoted text On 2015/11/05 22:29:16, danakj wrote: > do you need all gfx? or just geometry? Just geometry. Done.
	14 "+ui/events"

	15 ]

OLD	NEW

« no previous file with comments | « components/web_input/BUILD.gn ('k') | components/web_input/OWNERS » ('j') | no next file with comments »