Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Side by Side Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1415953002: Move two color related properties into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch for landing Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
9 * Copyright (C) 2012 Intel Corporation. All rights reserved. 9 * Copyright (C) 2012 Intel Corporation. All rights reserved.
10 * 10 *
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 /* nobreak */ 423 /* nobreak */
424 case CSSPropertyBackgroundColor: // <color> | inherit 424 case CSSPropertyBackgroundColor: // <color> | inherit
425 case CSSPropertyBorderTopColor: // <color> | inherit 425 case CSSPropertyBorderTopColor: // <color> | inherit
426 case CSSPropertyBorderRightColor: 426 case CSSPropertyBorderRightColor:
427 case CSSPropertyBorderBottomColor: 427 case CSSPropertyBorderBottomColor:
428 case CSSPropertyBorderLeftColor: 428 case CSSPropertyBorderLeftColor:
429 case CSSPropertyWebkitBorderStartColor: 429 case CSSPropertyWebkitBorderStartColor:
430 case CSSPropertyWebkitBorderEndColor: 430 case CSSPropertyWebkitBorderEndColor:
431 case CSSPropertyWebkitBorderBeforeColor: 431 case CSSPropertyWebkitBorderBeforeColor:
432 case CSSPropertyWebkitBorderAfterColor: 432 case CSSPropertyWebkitBorderAfterColor:
433 case CSSPropertyColor: // <color> | inherit
434 case CSSPropertyTextDecorationColor: // CSS3 text decoration colors 433 case CSSPropertyTextDecorationColor: // CSS3 text decoration colors
435 case CSSPropertyWebkitColumnRuleColor: 434 case CSSPropertyWebkitColumnRuleColor:
436 case CSSPropertyWebkitTextEmphasisColor: 435 case CSSPropertyWebkitTextEmphasisColor:
437 case CSSPropertyWebkitTextFillColor:
438 case CSSPropertyWebkitTextStrokeColor: 436 case CSSPropertyWebkitTextStrokeColor:
439 ASSERT(propId != CSSPropertyTextDecorationColor || RuntimeEnabledFeature s::css3TextDecorationsEnabled()); 437 ASSERT(propId != CSSPropertyTextDecorationColor || RuntimeEnabledFeature s::css3TextDecorationsEnabled());
440 parsedValue = parseColor(m_valueList->current(), acceptQuirkyColors(prop Id)); 438 parsedValue = parseColor(m_valueList->current(), acceptQuirkyColors(prop Id));
441 if (parsedValue) 439 if (parsedValue)
442 m_valueList->next(); 440 m_valueList->next();
443 break; 441 break;
444 442
445 case CSSPropertyCursor: { 443 case CSSPropertyCursor: {
446 // Grammar defined by CSS3 UI and modified by CSS4 images: 444 // Grammar defined by CSS3 UI and modified by CSS4 images:
447 // [ [<image> [<x> <y>]?,]* 445 // [ [<image> [<x> <y>]?,]*
(...skipping 582 matching lines...) Expand 10 before | Expand all | Expand 10 after
1030 ASSERT(RuntimeEnabledFeatures::cssGridLayoutEnabled()); 1028 ASSERT(RuntimeEnabledFeatures::cssGridLayoutEnabled());
1031 return parseGridShorthand(important); 1029 return parseGridShorthand(important);
1032 1030
1033 // End of CSS3 properties 1031 // End of CSS3 properties
1034 1032
1035 case CSSPropertyWebkitAppRegion: 1033 case CSSPropertyWebkitAppRegion:
1036 if (id >= CSSValueDrag && id <= CSSValueNoDrag) 1034 if (id >= CSSValueDrag && id <= CSSValueNoDrag)
1037 validPrimitive = true; 1035 validPrimitive = true;
1038 break; 1036 break;
1039 1037
1040 case CSSPropertyWebkitTapHighlightColor:
1041 parsedValue = parseColor(m_valueList->current());
1042 if (parsedValue)
1043 m_valueList->next();
1044 break;
1045
1046 /* shorthand properties */ 1038 /* shorthand properties */
1047 case CSSPropertyBackground: { 1039 case CSSPropertyBackground: {
1048 // Position must come before color in this array because a plain old "0" is a legal color 1040 // Position must come before color in this array because a plain old "0" is a legal color
1049 // in quirks mode but it's usually the X coordinate of a position. 1041 // in quirks mode but it's usually the X coordinate of a position.
1050 const CSSPropertyID properties[] = { CSSPropertyBackgroundImage, CSSProp ertyBackgroundRepeat, 1042 const CSSPropertyID properties[] = { CSSPropertyBackgroundImage, CSSProp ertyBackgroundRepeat,
1051 CSSPropertyBackgroundAttachment, CSSPropertyB ackgroundPosition, CSSPropertyBackgroundOrigin, 1043 CSSPropertyBackgroundAttachment, CSSPropertyB ackgroundPosition, CSSPropertyBackgroundOrigin,
1052 CSSPropertyBackgroundClip, CSSPropertyBackgro undColor, CSSPropertyBackgroundSize }; 1044 CSSPropertyBackgroundClip, CSSPropertyBackgro undColor, CSSPropertyBackgroundSize };
1053 return parseFillShorthand(propId, properties, WTF_ARRAY_LENGTH(propertie s), important); 1045 return parseFillShorthand(propId, properties, WTF_ARRAY_LENGTH(propertie s), important);
1054 } 1046 }
1055 case CSSPropertyWebkitMask: { 1047 case CSSPropertyWebkitMask: {
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
1238 case CSSPropertyTransitionDuration: 1230 case CSSPropertyTransitionDuration:
1239 case CSSPropertyAnimationFillMode: 1231 case CSSPropertyAnimationFillMode:
1240 case CSSPropertyAnimationIterationCount: 1232 case CSSPropertyAnimationIterationCount:
1241 case CSSPropertyAnimationName: 1233 case CSSPropertyAnimationName:
1242 case CSSPropertyAnimationPlayState: 1234 case CSSPropertyAnimationPlayState:
1243 case CSSPropertyAnimationTimingFunction: 1235 case CSSPropertyAnimationTimingFunction:
1244 case CSSPropertyTransitionTimingFunction: 1236 case CSSPropertyTransitionTimingFunction:
1245 case CSSPropertyTransitionProperty: 1237 case CSSPropertyTransitionProperty:
1246 case CSSPropertyOrphans: 1238 case CSSPropertyOrphans:
1247 case CSSPropertyWidows: 1239 case CSSPropertyWidows:
1240 case CSSPropertyWebkitTapHighlightColor:
1241 case CSSPropertyWebkitTextFillColor:
1242 case CSSPropertyColor:
1248 validPrimitive = false; 1243 validPrimitive = false;
1249 break; 1244 break;
1250 1245
1251 case CSSPropertyScrollSnapPointsX: 1246 case CSSPropertyScrollSnapPointsX:
1252 case CSSPropertyScrollSnapPointsY: 1247 case CSSPropertyScrollSnapPointsY:
1253 parsedValue = parseScrollSnapPoints(); 1248 parsedValue = parseScrollSnapPoints();
1254 break; 1249 break;
1255 case CSSPropertyScrollSnapCoordinate: 1250 case CSSPropertyScrollSnapCoordinate:
1256 parsedValue = parseScrollSnapCoordinate(); 1251 parsedValue = parseScrollSnapCoordinate();
1257 break; 1252 break;
(...skipping 5397 matching lines...) Expand 10 before | Expand all | Expand 10 after
6655 } 6650 }
6656 } 6651 }
6657 6652
6658 if (!list->length()) 6653 if (!list->length())
6659 return nullptr; 6654 return nullptr;
6660 6655
6661 return list.release(); 6656 return list.release();
6662 } 6657 }
6663 6658
6664 } // namespace blink 6659 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698