Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Side by Side Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1415953002: Move two color related properties into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix another test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
9 * Copyright (C) 2012 Intel Corporation. All rights reserved. 9 * Copyright (C) 2012 Intel Corporation. All rights reserved.
10 * 10 *
(...skipping 414 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 /* nobreak */ 425 /* nobreak */
426 case CSSPropertyBackgroundColor: // <color> | inherit 426 case CSSPropertyBackgroundColor: // <color> | inherit
427 case CSSPropertyBorderTopColor: // <color> | inherit 427 case CSSPropertyBorderTopColor: // <color> | inherit
428 case CSSPropertyBorderRightColor: 428 case CSSPropertyBorderRightColor:
429 case CSSPropertyBorderBottomColor: 429 case CSSPropertyBorderBottomColor:
430 case CSSPropertyBorderLeftColor: 430 case CSSPropertyBorderLeftColor:
431 case CSSPropertyWebkitBorderStartColor: 431 case CSSPropertyWebkitBorderStartColor:
432 case CSSPropertyWebkitBorderEndColor: 432 case CSSPropertyWebkitBorderEndColor:
433 case CSSPropertyWebkitBorderBeforeColor: 433 case CSSPropertyWebkitBorderBeforeColor:
434 case CSSPropertyWebkitBorderAfterColor: 434 case CSSPropertyWebkitBorderAfterColor:
435 case CSSPropertyColor: // <color> | inherit
436 case CSSPropertyTextDecorationColor: // CSS3 text decoration colors 435 case CSSPropertyTextDecorationColor: // CSS3 text decoration colors
437 case CSSPropertyWebkitColumnRuleColor: 436 case CSSPropertyWebkitColumnRuleColor:
438 case CSSPropertyWebkitTextEmphasisColor: 437 case CSSPropertyWebkitTextEmphasisColor:
439 case CSSPropertyWebkitTextFillColor:
440 case CSSPropertyWebkitTextStrokeColor: 438 case CSSPropertyWebkitTextStrokeColor:
441 ASSERT(propId != CSSPropertyTextDecorationColor || RuntimeEnabledFeature s::css3TextDecorationsEnabled()); 439 ASSERT(propId != CSSPropertyTextDecorationColor || RuntimeEnabledFeature s::css3TextDecorationsEnabled());
442 parsedValue = parseColor(m_valueList->current(), acceptQuirkyColors(prop Id)); 440 parsedValue = parseColor(m_valueList->current(), acceptQuirkyColors(prop Id));
443 if (parsedValue) 441 if (parsedValue)
444 m_valueList->next(); 442 m_valueList->next();
445 break; 443 break;
446 444
447 case CSSPropertyCursor: { 445 case CSSPropertyCursor: {
448 // Grammar defined by CSS3 UI and modified by CSS4 images: 446 // Grammar defined by CSS3 UI and modified by CSS4 images:
449 // [ [<image> [<x> <y>]?,]* 447 // [ [<image> [<x> <y>]?,]*
(...skipping 582 matching lines...) Expand 10 before | Expand all | Expand 10 after
1032 ASSERT(RuntimeEnabledFeatures::cssGridLayoutEnabled()); 1030 ASSERT(RuntimeEnabledFeatures::cssGridLayoutEnabled());
1033 return parseGridShorthand(important); 1031 return parseGridShorthand(important);
1034 1032
1035 // End of CSS3 properties 1033 // End of CSS3 properties
1036 1034
1037 case CSSPropertyWebkitAppRegion: 1035 case CSSPropertyWebkitAppRegion:
1038 if (id >= CSSValueDrag && id <= CSSValueNoDrag) 1036 if (id >= CSSValueDrag && id <= CSSValueNoDrag)
1039 validPrimitive = true; 1037 validPrimitive = true;
1040 break; 1038 break;
1041 1039
1042 case CSSPropertyWebkitTapHighlightColor:
1043 parsedValue = parseColor(m_valueList->current());
1044 if (parsedValue)
1045 m_valueList->next();
1046 break;
1047
1048 /* shorthand properties */ 1040 /* shorthand properties */
1049 case CSSPropertyBackground: { 1041 case CSSPropertyBackground: {
1050 // Position must come before color in this array because a plain old "0" is a legal color 1042 // Position must come before color in this array because a plain old "0" is a legal color
1051 // in quirks mode but it's usually the X coordinate of a position. 1043 // in quirks mode but it's usually the X coordinate of a position.
1052 const CSSPropertyID properties[] = { CSSPropertyBackgroundImage, CSSProp ertyBackgroundRepeat, 1044 const CSSPropertyID properties[] = { CSSPropertyBackgroundImage, CSSProp ertyBackgroundRepeat,
1053 CSSPropertyBackgroundAttachment, CSSPropertyB ackgroundPosition, CSSPropertyBackgroundOrigin, 1045 CSSPropertyBackgroundAttachment, CSSPropertyB ackgroundPosition, CSSPropertyBackgroundOrigin,
1054 CSSPropertyBackgroundClip, CSSPropertyBackgro undColor, CSSPropertyBackgroundSize }; 1046 CSSPropertyBackgroundClip, CSSPropertyBackgro undColor, CSSPropertyBackgroundSize };
1055 return parseFillShorthand(propId, properties, WTF_ARRAY_LENGTH(propertie s), important); 1047 return parseFillShorthand(propId, properties, WTF_ARRAY_LENGTH(propertie s), important);
1056 } 1048 }
1057 case CSSPropertyWebkitMask: { 1049 case CSSPropertyWebkitMask: {
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
1240 case CSSPropertyTransitionDuration: 1232 case CSSPropertyTransitionDuration:
1241 case CSSPropertyAnimationFillMode: 1233 case CSSPropertyAnimationFillMode:
1242 case CSSPropertyAnimationIterationCount: 1234 case CSSPropertyAnimationIterationCount:
1243 case CSSPropertyAnimationName: 1235 case CSSPropertyAnimationName:
1244 case CSSPropertyAnimationPlayState: 1236 case CSSPropertyAnimationPlayState:
1245 case CSSPropertyAnimationTimingFunction: 1237 case CSSPropertyAnimationTimingFunction:
1246 case CSSPropertyTransitionTimingFunction: 1238 case CSSPropertyTransitionTimingFunction:
1247 case CSSPropertyTransitionProperty: 1239 case CSSPropertyTransitionProperty:
1248 case CSSPropertyOrphans: 1240 case CSSPropertyOrphans:
1249 case CSSPropertyWidows: 1241 case CSSPropertyWidows:
1242 case CSSPropertyWebkitTapHighlightColor:
1243 case CSSPropertyWebkitTextFillColor:
1244 case CSSPropertyColor:
1250 validPrimitive = false; 1245 validPrimitive = false;
1251 break; 1246 break;
1252 1247
1253 case CSSPropertyScrollSnapPointsX: 1248 case CSSPropertyScrollSnapPointsX:
1254 case CSSPropertyScrollSnapPointsY: 1249 case CSSPropertyScrollSnapPointsY:
1255 parsedValue = parseScrollSnapPoints(); 1250 parsedValue = parseScrollSnapPoints();
1256 break; 1251 break;
1257 case CSSPropertyScrollSnapCoordinate: 1252 case CSSPropertyScrollSnapCoordinate:
1258 parsedValue = parseScrollSnapCoordinate(); 1253 parsedValue = parseScrollSnapCoordinate();
1259 break; 1254 break;
(...skipping 5416 matching lines...) Expand 10 before | Expand all | Expand 10 after
6676 } 6671 }
6677 } 6672 }
6678 6673
6679 if (!list->length()) 6674 if (!list->length())
6680 return nullptr; 6675 return nullptr;
6681 6676
6682 return list.release(); 6677 return list.release();
6683 } 6678 }
6684 6679
6685 } // namespace blink 6680 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698