Chromium Code Reviews

Issue 1415943009: Add BIC(register) and BIC(immediate) to ARM integrated assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+124 lines, -2 lines)
M src/DartARM32/assembler_arm.h View 1 chunk +3 lines, -0 lines 0 comments
M src/DartARM32/assembler_arm.cc View 1 chunk +4 lines, -2 lines 0 comments
M src/IceAssemblerARM32.h View 1 chunk +3 lines, -0 lines 0 comments
M src/IceAssemblerARM32.cpp View 1 chunk +18 lines, -0 lines 0 comments
M src/IceInstARM32.cpp View 1 chunk +7 lines, -0 lines 0 comments
A tests_lit/assembler/arm32/bic.ll View 1 chunk +89 lines, -0 lines 0 comments

Messages

Total messages: 6 (2 generated)
Karl
5 years, 1 month ago (2015-11-02 16:47:26 UTC) #3
John
lgtm
5 years, 1 month ago (2015-11-02 17:49:46 UTC) #4
Jim Stichnoth
lgtm
5 years, 1 month ago (2015-11-02 18:44:09 UTC) #5
Karl
5 years, 1 month ago (2015-11-02 23:01:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4f8805b70917bf0de9ba277a0af2d6f1d582be52 (presubmit successful).

Powered by Google App Engine