components/component_updater/component_updater_service.cc - Issue 1415933011: Change the update_client task runner behavior to continue on shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/component_updater/component_updater_service.cc

Issue 1415933011: Change the update_client task runner behavior to continue on shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment updates Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/chrome_component_updater_configurator.cc ('k') | components/component_updater/component_updater_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/component_updater/component_updater_service.cc

diff --git a/components/component_updater/component_updater_service.cc b/components/component_updater/component_updater_service.cc

index 29b120ea45bf5c81581f424aa4138a2806b9703a..1c49d262e8ddcb518fccc5077a33f1370441d2f9 100644

--- a/components/component_updater/component_updater_service.cc

+++ b/components/component_updater/component_updater_service.cc

@@ -89,6 +89,7 @@ void CrxUpdateService::Stop() {

DCHECK(thread_checker_.CalledOnValidThread());

VLOG(1) << "CrxUpdateService stopping";

timer_.Stop();

+ update_client_->Stop();

}

// Adds a component to be checked for upgrades. If the component exists it