A64: Implement Smi support in MathAbs

src/a64/lithium-a64.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2359 matching lines @@
 
   return new(zone()) LTypeofIsAndBranch(
       UseRegister(instr->value()), temp1, temp2);
 }
 
 
 LInstruction* LChunkBuilder::DoUnaryMathOperation(HUnaryMathOperation* instr) {
   switch (instr->op()) {
     case kMathAbs: {
       Representation r = instr->representation();
-      // TODO(jbramley): Support smis in LMathAbs and use that.
-      if (r.IsTagged() || r.IsSmi()) {
+      if (r.IsTagged()) {
         // The tagged case might need to allocate a HeapNumber for the result,
         // so it is handled by a separate LInstruction.
         LOperand* input = UseRegister(instr->value());
         LOperand* temp1 = TempRegister();
         LOperand* temp2 = TempRegister();
         LOperand* temp3 = TempRegister();
         LMathAbsTagged* result =
             new(zone()) LMathAbsTagged(input, temp1, temp2, temp3);
         return AssignEnvironment(AssignPointerMap(DefineAsRegister(result)));
       } else {
         LOperand* input = UseRegisterAtStart(instr->value());
         LMathAbs* result = new(zone()) LMathAbs(input);
         if (r.IsDouble()) {
           // The Double case can never fail so it doesn't need an environment.
           return DefineAsRegister(result);
         } else {
-          ASSERT(r.IsInteger32());
-          // The Integer32 case needs an environment because it can deoptimize
-          // on INT_MIN.
+          ASSERT(r.IsInteger32() || r.IsSmi());
+          // The Integer32 and Smi cases need an environment because they can
+          // deoptimize on minimum representable number.
           return AssignEnvironment(DefineAsRegister(result));
         }
       }
     }
     case kMathCos: {
       ASSERT(instr->representation().IsDouble());
       ASSERT(instr->value()->representation().IsDouble());
       LOperand* input = UseFixedDouble(instr->value(), d0);
       LMathCos* result = new(zone()) LMathCos(input);
       return MarkAsCall(DefineFixedDouble(result, d0), instr);
@@ skipping 134 matching lines @@
 LInstruction* LChunkBuilder::DoWrapReceiver(HWrapReceiver* instr) {
   LOperand* receiver = UseRegister(instr->receiver());
   LOperand* function = UseRegisterAtStart(instr->function());
   LOperand* temp = TempRegister();
   LWrapReceiver* result = new(zone()) LWrapReceiver(receiver, function, temp);
   return AssignEnvironment(DefineAsRegister(result));
 }
 
 
 } }  // namespace v8::internal